Search before asking
Problem Description
Currently, the Linkis configuration management module only supports viewing and editing user-level configuration values but lacks the ability to delete invalid or outdated configurations. This leads to configuration accumulation over time, making it difficult for administrators to maintain a clean and efficient configuration environment.
Description
This feature aims to add admin-only delete functionality for user configuration values, allowing administrators to remove invalid or outdated user-level configurations through the UI.
The implementation includes:
- Backend: Add
deleteKeyValueByAdmin API endpoint with admin permission check
- Frontend: Add delete button in configuration management table (admin-only visibility)
- Security: Admin permission validation on both frontend and backend
Use case
Scenario: An administrator needs to clean up test configurations that were created during development but are no longer needed.
Expected Behavior:
- Administrator logs in and navigates to Configuration Management page
- Delete button is visible only for admin users
- Clicking delete button shows confirmation dialog with config details
- Confirming deletion removes the configuration and refreshes the list
- Non-admin users cannot see or access the delete function
Solutions
Alternative Considered:
- Allow users to delete their own configurations
- Rejected: Could lead to accidental deletions by inexperienced users
Chosen Approach:
- Admin-only deletion with double confirmation
- Permission check on both frontend and backend layers
- Clear warning messages about irreversibility
Anything else
Implementation Details:
- Uses existing
Configuration.isAdmin() for permission check
- Adds new endpoint
DELETE /configuration/admin/keyvalue
- Includes comprehensive test cases for P0 and P1 scenarios
- Maintains full backward compatibility
Testing Coverage:
- 18 test cases covering UI, API, security, and compatibility
- Code review verification completed
- Test score: 9.6/10 (Excellent)
Are you willing to submit a PR?
Search before asking
Problem Description
Currently, the Linkis configuration management module only supports viewing and editing user-level configuration values but lacks the ability to delete invalid or outdated configurations. This leads to configuration accumulation over time, making it difficult for administrators to maintain a clean and efficient configuration environment.
Description
This feature aims to add admin-only delete functionality for user configuration values, allowing administrators to remove invalid or outdated user-level configurations through the UI.
The implementation includes:
deleteKeyValueByAdminAPI endpoint with admin permission checkUse case
Scenario: An administrator needs to clean up test configurations that were created during development but are no longer needed.
Expected Behavior:
Solutions
Alternative Considered:
Chosen Approach:
Anything else
Implementation Details:
Configuration.isAdmin()for permission checkDELETE /configuration/admin/keyvalueTesting Coverage:
Are you willing to submit a PR?