Skip to content

Commit 4658e23

Browse files
wip
1 parent 410a8b8 commit 4658e23

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

scripts/test/shared.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -440,7 +440,7 @@ def get_tests(test_dir, extensions=[], recursive=False):
440440
'func.wast', # Duplicate parameter names not properly rejected
441441
'global.wast', # Fail to parse table
442442
'if.wast', # Requires more precise unreachable validation
443-
'imports.wast', # Missing validation of missing function on instantiation
443+
# 'imports.wast', # Missing validation of missing function on instantiation
444444
'proposals/threads/imports.wast', # Missing memory type validation on instantiation
445445
'linking.wast', # Missing function type validation on instantiation
446446
'proposals/threads/memory.wast', # Missing memory type validation on instantiation

src/wasm-interpreter.h

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3309,8 +3309,10 @@ class ModuleRunnerBase : public ExpressionRunner<SubType> {
33093309
linkedInstances.at((*memory)->module).get();
33103310
Export* export_ =
33113311
importedInstance->wasm.getExportOrNull((*memory)->base);
3312-
Memory* exportedMemory =
3313-
importedInstance->wasm.getMemory(*export_->getInternalName());
3312+
Memory exportedMemory =
3313+
*importedInstance->wasm.getMemory(*export_->getInternalName());
3314+
exportedMemory.initial = importedInstance->getMemorySize();
3315+
// Address initial = importedInstance->getMemorySize();
33143316
if (!(*memory)->isSubType(*exportedMemory)) {
33153317
trap((std::stringstream()
33163318
<< "Imported memory isn't compatible. Imported memory: "

0 commit comments

Comments
 (0)