feat: Add CallRef functions to js api.
#8103
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
reviewed
Dec 8, 2025
src/js/binaryen.js-post.js
Outdated
| } | ||
| }; | ||
|
|
||
| self['call_ref'] = function(target, operands, type, isReturn) { |
Member
There was a problem hiding this comment.
It looks like call_indirect handles return calls differently - there is self.return_call_indirect instead of a param. But I see we have the same difference in the C API, so this PR is following that.
I think we might want to change the C API, but for now, how about making the JS API consistent with itself? That is, add self.return_call_ref.
Contributor
Author
There was a problem hiding this comment.
Made that change. Might be smart to open an issue for tracking the change on the c api.
spotandjake
force-pushed
the
spotandjake-js-callref
branch
from
3b2f848 to
07f5a59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first pr to Binaryen so I hope I did things correctly.
This pr implements the api's for working with
CallRefto the js api.module.call_refand the related info functions:
getNumOperands(expr)getOperandAt(expr, index)setOperandAt(expr, index, operandExpr)appendOperand(expr, operandExpr)insertOperandAt(expr, index, operandExpr)removeOperandAt(expr, index)getTarget(expr)setTarget(expr, targetExpr)isReturn(expr)setReturn(expr, isReturn)