Fix: force translations

Author: sysadm

README.md

@@ -1,7 +1,7 @@
 # webgate.pro
 
 [![CI](https://github.com/WebgateSystems/webgate.pro/actions/workflows/rubyonrails.yml/badge.svg)](https://github.com/WebgateSystems/webgate.pro/actions/workflows/rubyonrails.yml)
-![Coverage](https://img.shields.io/badge/coverage-95.3%25-brightgreen)
+![Coverage](https://img.shields.io/badge/coverage-95.1%25-brightgreen)
 [![Ruby](https://img.shields.io/badge/Ruby-3.2.2-CC342D?logo=ruby&logoColor=white)](https://www.ruby-lang.org/)
 [![Rails](https://img.shields.io/badge/Rails-7.0.10-D30001?logo=rubyonrails&logoColor=white)](https://rubyonrails.org/)
 [![License: GPL v3](https://img.shields.io/badge/License-GPLv3-blue.svg)](https://www.gnu.org/licenses/gpl-3.0)

app/interactors/base_interactor.rb

@@ -1,3 +1,29 @@
 class BaseInteractor
   include Interactor
+
+  private
+
+  # Some GPT clients return Hashes with symbol keys; normalize everything to string keys.
+  # Also accepts objects responding to `to_h`.
+  def normalize_answer_hash(answer)
+    hash = if answer.is_a?(Hash)
+             answer
+           else
+             (answer.respond_to?(:to_h) ? answer.to_h : {})
+           end
+    deep_stringify_keys(hash)
+  end
+
+  def deep_stringify_keys(obj)
+    case obj
+    when Hash
+      obj.each_with_object({}) do |(k, v), acc|
+        acc[k.to_s] = deep_stringify_keys(v)
+      end
+    when Array
+      obj.map { |v| deep_stringify_keys(v) }
+    else
+      obj
+    end
+  end
 end

app/interactors/member_translation.rb

@@ -365,7 +365,8 @@ def handle_field_retry(field, target_locale, retries, error)
 
   def save_translation(target_locale, answer_gpt)
     I18n.with_locale(target_locale) do
-      return unless answer_gpt.is_a?(Hash)
+      answer_gpt = normalize_answer_hash(answer_gpt)
+      return unless answer_gpt.is_a?(Hash) && answer_gpt.any?
 
       assign_translation_fields(answer_gpt)
       save_and_verify_translation(target_locale)

app/interactors/project_translation.rb

@@ -292,6 +292,7 @@ def log_chunk_failure(target_locale, index, error)
 
   def save_translation(target_locale, answer_gpt)
     I18n.with_locale(target_locale) do
+      answer_gpt = normalize_answer_hash(answer_gpt)
       return unless answer_gpt.is_a?(Hash) && answer_gpt['content'].present?
 
       save_content_translation(target_locale, answer_gpt)

spec/interactors/member_translation_spec.rb

@@ -17,6 +17,16 @@
     }
   end
 
+  let(:mock_translation_response_symbol_keys) do
+    {
+      name: 'John Doe',
+      job_title: 'Developer',
+      description: 'Description in English',
+      motto: 'Motto in English',
+      education: 'Education in English'
+    }
+  end
+
   before do
     # Mock EasyAccessGpt::Translation::SingleLocale
     # Use allow_any_instance_of for more reliable mocking in tests
@@ -104,6 +114,23 @@
       end
     end
 
+    context 'when translation API returns symbol keys' do
+      before do
+        allow_any_instance_of(EasyAccessGpt::Translation::SingleLocale)
+          .to receive(:call).and_return(mock_translation_response_symbol_keys)
+      end
+
+      it 'persists translated fields (does not fallback to Polish)' do
+        result = described_class.call(model: member, current_locale:, force_locale: :de)
+        expect(result).to be_success
+
+        member.reload
+        de_translation = member.translations.find_by(locale: 'de')
+        expect(de_translation).to be_present
+        expect(de_translation.name).to eq('John Doe')
+      end
+    end
+
     context 'when force_locale is provided' do
       it 'translates only the specified locale' do
         result = described_class.call(