Better cooked package replacement check

[Xymanek]

Currently the version check is done via templates, which was invented when XComGame was the only package being replaced. This has 2 downsides:

1. Cannot use this info in CreateTemplates (or OnPreCreateTemplates)
2. It relies on XComGame creating templates for other packages, which makes it unreliable for error detection since it will report Engine replacement as missing if XComGame one wasn't loaded

While we cannot remove the existing approach due to BC, I propose we switch to a method of class-is-not-none and then getting default values, similar to how the CHEngineVersion template is created, in places which we control (eg. shell) and in future additions (eg. DLC2, #764)

X2WOTCCommunityHighlander/X2WOTCCommunityHighlander/Src/Engine/Classes/CHEngineVersion.uc

Lines 1 to 2 in fb9537d

	// CHL: We can't create templates in Engine, so we use this to create the template in XComGame
	class CHEngineVersion extends Object;

X2WOTCCommunityHighlander/X2WOTCCommunityHighlander/Src/XComGame/Classes/CHXComGameVersion.uc

Lines 25 to 35 in fb9537d

	if (class'Engine.CHEngineVersion' != none)
	{
	class'X2TacticalGameRuleset'.static.ReleaseScriptLog("X2WOTCCommunityHighlander: Creating Engine version template...");
	`CREATE_X2TEMPLATE(class'CHXComGameVersionTemplate', XComGameVersion, 'CHEngineVersion');
	XComGameVersion.MajorVersion = class'Engine.CHEngineVersion'.default.MajorVersion;
	XComGameVersion.MinorVersion = class'Engine.CHEngineVersion'.default.MinorVersion;
	XComGameVersion.PatchVersion = class'Engine.CHEngineVersion'.default.PatchVersion;
	XComGameVersion.Commit = class'Engine.CHEngineVersion'.default.Commit;
	class'X2TacticalGameRuleset'.static.ReleaseScriptLog("X2WOTCCommunityHighlander: Created Engine version template with version" @ XComGameVersion.MajorVersion $ "." $ XComGameVersion.MinorVersion $ "." $ XComGameVersion.PatchVersion);
	Templates.AddItem(XComGameVersion);
	}

X2WOTCCommunityHighlander/X2WOTCCommunityHighlander/Src/X2WOTCCommunityHighlander/Classes/X2WOTCCH_Components.uc

Lines 46 to 47 in fb9537d

	Comps.AddItem(BuildComponent(Manager.FindStrategyElementTemplate('CHEngineVersion'), SelfVersion, "Engine", true, true));
	Comps.AddItem(BuildComponent(Manager.FindStrategyElementTemplate('CHXComGameVersion'), SelfVersion, "XComGame", true, true));

[robojumper]

There are two options, each with their own drawbacks:

1. We create entirely separate subclasses of Object in every package. We thus lose the reflective capabilities of the system, so we have to compile against every package whose version we want to check, as opposed to only XComGame with CHXComGameVersionTemplate

2. We create a common base class CHAbstractVersion with the relevant properties, and create a subclass in every package with defaultproperties so that users could load the CDO by name (either DLO or through XCom?Engine) and inspect it as a CHAbstractVersion. This makes the situation worse if the Core replacement fails to load because then all other subclass packages fail to load entirely.

[Xymanek]

We thus lose the reflective capabilities of the system

Could you elaborate on this?

[robojumper]

We can't check the version of a component by name anymore, we have to use the specific class and we have to compile against this class beforehand. Compared to the current system, where we only need the template type and can request and inspect them by name without requiring building against CHCoreVersion, for example.

[Xymanek]

I see no issue in needing to build against all CHL-replaced packages if you want to check all of their versions. Why would you do otherwise?

Compared to the current system, where we only need the template type

Which sits in XComGame and will poof if said replacement isn't loaded

[robojumper]

Let's go with your approach. The improvements far outweigh the drawback I mentioned.

[Xymanek]

Fully implemented in #764