Skip to content

Commit 6e36961

Browse files
committed
remove failure hook
1 parent cb618b1 commit 6e36961

File tree

1 file changed

+3
-27
lines changed

1 file changed

+3
-27
lines changed

mod_auth_memcookie.c

Lines changed: 3 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -374,7 +374,7 @@ static int Auth_memCookie_Return_Safe_Unauthorized(request_rec *r)
374374
*
375375
* Auth_memCookie_check_cookie
376376
*
377-
* This is the authentification phase (authn), they verify
377+
* This is the Authentication phase (authn), they verify
378378
* if authentification cookie is set and if is know in memcache server.
379379
*
380380
* If the login is not valid, a 401 Not Authorized will be returned.
@@ -517,7 +517,7 @@ static int Auth_memCookie_check_cookie(request_rec *r)
517517
*
518518
* Auth_memCookie_check_auth
519519
*
520-
* Authentification phase in apache >2.3 :
520+
* Authorization phase (authz) in apache >2.3 :
521521
* Checking authoriszation group for the authenticated cookie
522522
**************************************************/
523523

@@ -593,7 +593,7 @@ static authz_status Auth_memCookie_group_authz_checker(request_rec *r, const cha
593593
*
594594
* Auth_memCookie_check_auth
595595
*
596-
* Authentification phase in apache 2.0 to 2.2 :
596+
* Authorization phase in apache 2.0 to 2.2 :
597597
* Checking authoriszation for user and group of the authenticated cookie
598598
**************************************************/
599599

@@ -724,27 +724,6 @@ static const authz_provider Auth_memCookie_authz_group_provider = {
724724
&Auth_memCookie_authz_parse_config,
725725
};
726726

727-
/**************************************************************
728-
*
729-
* hook_note_auth_failure
730-
*
731-
* Make http redirect when authentication/authorization fail.
732-
*
733-
*************************************************************/
734-
static int hook_note_auth_failure(request_rec * r, const char *auth_type)
735-
{
736-
if (strcasecmp(auth_type, "cookie"))
737-
return DECLINED;
738-
739-
auth_form_config_rec *conf = ap_get_module_config(r->per_dir_config,
740-
&auth_form_module);
741-
742-
if (conf->location && ap_strchr_c(conf->location, ':')) {
743-
apr_table_setn(r->err_headers_out, "Location", conf->location);
744-
}
745-
return OK;
746-
}
747-
748727
#endif
749728

750729
/**************************************************
@@ -763,9 +742,6 @@ static void register_hooks(apr_pool_t *p)
763742
&Auth_memCookie_authz_group_provider,
764743
AP_AUTH_INTERNAL_PER_CONF);
765744

766-
ap_hook_note_auth_failure(hook_note_auth_failure, NULL, NULL,
767-
APR_HOOK_MIDDLE);
768-
769745
#else
770746
// apache 2.0 to 2.2 model
771747
ap_hook_check_user_id(Auth_memCookie_check_cookie, NULL, NULL, APR_HOOK_FIRST);

0 commit comments

Comments
 (0)