No default config

[willdurand]

The code expects src/config.js to exist and to be a valid configuration file. Currently, we ignore this file and yarn lint outputs an error because the file may not exist. We should provide a default config file or handle optional config file differently.

[mikbry]

Is this bug fixed ?

[willdurand]

Not really, maybe adding a CLI would mitigate the issue but it is not urgent I'd say.

[mikbry]

okay

[licarth]

I think we should address this issue, I lost quite some time understanding that the issue was coming from zoapp-backend and not the backend itself.

Right now, running yarn lint gives :

~/p/o/zoapp-backend (master|✔) $ yarn lint
yarn run v1.9.2
warning ../../../package.json: No license field
$ eslint src test

/home/thomas/projects/opla/zoapp-backend/src/index.js
  8:20  error  Unable to resolve path to module './config'  import/no-unresolved
  8:20  error  Missing file extension for "./config"        import/extensions

✖ 2 problems (2 errors, 0 warnings)

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

and yarn dev gives :

~/p/o/zoapp-backend (master|✔) $ yarn dev
yarn run v1.9.2
warning ../../../package.json: No license field
$ yarn compile:dev && yarn start:dev
warning ../../../package.json: No license field
$ yarn clean-dist && babel src -s -D -d dist && cp -f ./package.json ./dist/package.json && cp -f ./LICENSE ./dist/LICENSE && cp -f ./README.md ./dist/README.md
warning ../../../package.json: No license field
$ rm -r -f dist && mkdir dist
src/app.js -> dist/app.js
src/constraints/EmailParameters.js -> dist/constraints/EmailParameters.js
src/controllers/abstractController.js -> dist/controllers/abstractController.js
src/controllers/admin.js -> dist/controllers/admin.js
src/controllers/index.js -> dist/controllers/index.js
src/controllers/middlewares.js -> dist/controllers/middlewares.js
src/controllers/users.js -> dist/controllers/users.js
src/index.js -> dist/index.js
src/models/abstractModel.js -> dist/models/abstractModel.js
src/models/middlewares.js -> dist/models/middlewares.js
src/models/parameters.js -> dist/models/parameters.js
src/models/users.js -> dist/models/users.js
src/plugins/index.js -> dist/plugins/index.js
src/plugins/localtunnel/index.js -> dist/plugins/localtunnel/index.js
src/routes/admin.js -> dist/routes/admin.js
src/routes/common.js -> dist/routes/common.js
src/routes/dummy.js -> dist/routes/dummy.js
src/routes/index.js -> dist/routes/index.js
src/routes/users.js -> dist/routes/users.js
src/server.js -> dist/server.js
src/utils/middleware.js -> dist/utils/middleware.js
src/utils/tunnelProvider.js -> dist/utils/tunnelProvider.js
src/websocket/index.js -> dist/websocket/index.js
src/zoapp.js -> dist/zoapp.js
warning ../../../package.json: No license field
$ nodemon -w src --exec "babel-node src "
[nodemon] 1.17.1
[nodemon] to restart at any time, enter `rs`
[nodemon] watching: /home/thomas/projects/opla/zoapp-backend/src/**/*
[nodemon] starting `babel-node src`
module.js:549
    throw err;
    ^

Error: Cannot find module './config'
    at Function.Module._resolveFilename (module.js:547:15)
    at Function.Module._load (module.js:474:25)
    at Module.require (module.js:596:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/home/thomas/projects/opla/zoapp-backend/src/index.js:8:1)
    at Module._compile (module.js:652:30)
    at loader (/home/thomas/projects/opla/zoapp-backend/node_modules/babel-register/lib/node.js:144:5)
    at Object.require.extensions.(anonymous function) [as .js] (/home/thomas/projects/opla/zoapp-backend/node_modules/babel-register/lib/node.js:154:7)
    at Module.load (module.js:565:32)
    at tryModuleLoad (module.js:505:12)
[nodemon] app crashed - waiting for file changes before starting...

[mikbry]

@licarth this issue is fixed ?