Identify install path better in Linux (#30)

Author: a9183756-gh

Arduino/System/PackagePathIndex.cmake

@@ -19,9 +19,10 @@ function(InitializeArduinoPackagePathList)
 
 	if (${CMAKE_HOST_APPLE})
 
-		set(install_search_paths "$ENV{HOME}/Applications" /Applications /Developer/Applications
-			/sw /opt/local)
-		set(install_path_suffixes Arduino.app/Contents/Java Arduino.app/Contents/Resources/Java)
+		set(install_search_paths "$ENV{HOME}/Applications" /Applications
+			/Developer/Applications /sw /opt/local)
+		set(install_path_suffixes Arduino.app/Contents/Java
+			Arduino.app/Contents/Resources/Java)
 
 		file(GLOB package_search_paths "$ENV{HOME}/Library/Arduino15")
 		set(package_path_suffixes "")
@@ -31,10 +32,40 @@ function(InitializeArduinoPackagePathList)
 
 	elseif (${CMAKE_HOST_UNIX}) # Probably Linux or some unix-like
 
-		file(GLOB install_search_paths /usr/share/arduino* /opt/local/arduino* /opt/arduino*
-			/usr/local/share/arduino* "$ENV{HOME}/opt/arduino*")
+		set(install_search_paths)
 		set(install_path_suffixes "")
 
+		# Resolve from arduino executable path
+		execute_process(COMMAND which arduino OUTPUT_VARIABLE _bin_path
+			ERROR_VARIABLE _ignore RESULT_VARIABLE _cmd_result)
+		if (_cmd_result STREQUAL 0)
+			string(STRIP "${_bin_path}" _bin_path)
+			execute_process(COMMAND readlink -f "${_bin_path}"
+				OUTPUT_VARIABLE _link_path RESULT_VARIABLE _cmd_result)
+			if (_cmd_result STREQUAL 0)
+				string(STRIP "${_link_path}" _bin_path)
+			endif()
+			get_filename_component(_install_path "${_bin_path}" DIRECTORY)
+			list(APPEND install_search_paths "${_install_path}")
+		else() # Resolve from application shortcut
+			set(_app_path "$ENV{HOME}/.local/share/applications")
+			if (EXISTS "${_app_path}/arduino-arduinoide.desktop")
+				file(STRINGS "${_app_path}/arduino-arduinoide.desktop"
+					_exec_prop REGEX "^Exec=")
+				if ("${_exec_prop}" MATCHES "^Exec=\"?(.*)\"?")
+					get_filename_component(_install_path "${CMAKE_MATCH_1}"
+						DIRECTORY)
+					list(APPEND install_search_paths "${_install_path}")
+				endif()
+			endif()
+		endif()
+
+		# Other usual locations
+		file(GLOB other_search_paths "$ENV{HOME}/.local/share/arduino*"
+			/usr/share/arduino* /usr/local/share/arduino* /opt/local/arduino*
+			/opt/arduino* "$ENV{HOME}/opt/arduino*")
+		list(APPEND install_search_paths "${other_search_paths}")
+
 		file(GLOB package_search_paths "$ENV{HOME}/.arduino15")
 		set(package_path_suffixes "")
 
@@ -44,18 +75,23 @@ function(InitializeArduinoPackagePathList)
 	elseif (${CMAKE_HOST_WIN32})
 
 		set(Prog86Path "ProgramFiles(x86)")
-		set(install_search_paths "$ENV{${Prog86Path}}/Arduino" "$ENV{ProgramFiles}/Arduino")
+		set(install_search_paths "$ENV{${Prog86Path}}/Arduino"
+			"$ENV{ProgramFiles}/Arduino")
 		set(install_path_suffixes "")
 
 		file(GLOB package_search_paths "$ENV{LOCALAPPDATA}/Arduino15")
 		set(package_path_suffixes "")
 
+		set(_reg_software "HKEY_LOCAL_MACHINE\\SOFTWARE")
+		set(_reg_win "${_reg_software}\\Microsoft\\Windows\\CurrentVersion")
+		set(_reg_explorer "${_reg_win}\\Explorer")
 		file(GLOB sketchbook_search_paths "$ENV{LOCALAPPDATA}/Arduino15"
-			"[HKEY_LOCAL_MACHINE\\SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Explorer\\User Shell Folders;Personal]/ArduinoData")
+			"[${_reg_explorer}\\User Shell Folders;Personal]/ArduinoData")
 		set(sketchbook_path_suffixes "")
 	else()
 
-		message(FATAL_ERROR "Host system ${CMAKE_HOST_SYSTEM} is not supported!!!")
+		message(FATAL_ERROR
+			"Host system ${CMAKE_HOST_SYSTEM} is not supported!!!")
 
 	endif()
 
@@ -71,6 +107,15 @@ function(InitializeArduinoPackagePathList)
 		message(FATAL_ERROR "Arduino IDE installation is not found!!!\n"
 			"Use -DARDUINO_INSTALL_PATH=<path> to manually specify the path\n"
 		)
+	elseif(ARDUINO_INSTALL_PATH AND NOT "${ARDUINO_ENABLE_PACKAGE_MANAGER}"
+        AND "${ARDUINO_BOARD_MANAGER_URL}" STREQUAL "")
+		message("${ARDUINO_INSTALL_PATH}")
+		file(READ "${ARDUINO_INSTALL_PATH}/lib/version.txt" _version)
+		string(REGEX MATCH "[0-9]+\\.[0-9]" _ard_version "${_version}")
+		if (_version AND "${_ard_version}" VERSION_LESS "1.5")
+			message(WARNING "${ARDUINO_INSTALL_PATH} may be unsupported version "
+				"${_version}. Please install newer version!")
+		endif()
 	endif()
 	# message("ARDUINO_INSTALL_PATH:${ARDUINO_INSTALL_PATH}")