From 46caa9a58e357737b345f92e32af57c99094e75d Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Wed, 17 Jun 2026 22:30:51 +0000 Subject: [PATCH 1/3] =?UTF-8?q?=F0=9F=8E=A8=20Palette:=20Add=20ARIA=20attr?= =?UTF-8?q?ibutes=20to=20More=20options=20button=20in=20EventAnnotations?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: aarjava <218419324+aarjava@users.noreply.github.com> --- .Jules/palette.md | 3 +++ src/components/events/EventAnnotations.tsx | 5 ++++- 2 files changed, 7 insertions(+), 1 deletion(-) create mode 100644 .Jules/palette.md diff --git a/.Jules/palette.md b/.Jules/palette.md new file mode 100644 index 00000000..79400b6f --- /dev/null +++ b/.Jules/palette.md @@ -0,0 +1,3 @@ +## 2025-02-12 - Added ARIA attributes to icon-only More options button +**Learning:** Icon-only buttons that trigger menus or dialogs often lack the necessary ARIA attributes to communicate their state and purpose to screen readers. In `EventAnnotations.tsx`, the `MoreHorizontal` button was missing `aria-label`, `aria-expanded`, and `aria-haspopup`. +**Action:** When implementing togglable menu triggers (e.g., 'More actions' buttons), always ensure they include an 'aria-expanded' attribute reflecting their current state, a descriptive 'aria-label', an 'aria-haspopup' attribute (e.g., 'menu'), and 'aria-hidden="true"' on any purely decorative internal icons. diff --git a/src/components/events/EventAnnotations.tsx b/src/components/events/EventAnnotations.tsx index aefd7007..88ded451 100644 --- a/src/components/events/EventAnnotations.tsx +++ b/src/components/events/EventAnnotations.tsx @@ -325,8 +325,11 @@ export default function EventAnnotations({ setShowActionsFor(showActionsFor === thread.id ? null : thread.id) } className="rounded-lg p-1.5 text-[#9CA3AF] hover:bg-[#F8FAFC] hover:text-[#666666] transition-colors" + aria-label="More actions" + aria-expanded={showActionsFor === thread.id} + aria-haspopup="menu" > - +