static var refactors

Author: abhisheksarkar30

apps/excel-diff-checker.jar

@@ -16,8 +16,9 @@
  */
 public class ExcelDiffChecker {
 
-	static boolean diffFound = false;
-	static boolean commentFlag = true;
+	private static boolean success = true;
+	private static boolean diffFound = false;
+	private static boolean commentFlag = true;
 
 	public static void main(String[] args) {
 
@@ -27,8 +28,6 @@ public static void main(String[] args) {
 
 		String RESULT_FILE = FILE_NAME1.substring(0, FILE_NAME1.lastIndexOf(".")) + " vs " + FILE_NAME2;
 
-		boolean success = true;
-
 		File resultFile = new File(RESULT_FILE);
 		if(resultFile.exists())
 			resultFile.delete();
@@ -81,14 +80,17 @@ public static void main(String[] args) {
 								if(Utility.hasContent(cell2)) {
 									if(cell1 == null)
 										cell1 = row1.createCell(columnIndex);
-
+									
+									diffFound = true;
 									Utility.processDiff(cell1, cell2, commentFlag);
 								}
 							} else if(Utility.hasNoContent(cell2)) {
 								if(Utility.hasContent(cell1)) {
+									diffFound = true;
 									Utility.processDiff(cell1, null, commentFlag);
 								}
 							} else if(!cell1.getRawValue().equals(cell2.getRawValue())) {
+								diffFound = true;
 								Utility.processDiff(cell1, cell2, commentFlag);
 							}
 						}

src/main/java/edu/abhi/poi/excel/ExcelDiffChecker.java

@@ -33,8 +33,6 @@ public static void processDiff(XSSFCell cell1, XSSFCell cell2, boolean commentFl
 
 		System.out.println(String.format("Diff at cell[%s] of sheet[%s]", cell1.getReference(), sheet.getSheetName()));
 
-		ExcelDiffChecker.diffFound = true;
-		
 		if(!commentFlag) {
 			System.out.println(String.format("Expected: [%s], Found: [%s]", getCellValue(cell1), getCellValue(cell2)));
 			return;