Skip to content

Fix TestFactories.liveMap factory method to pass required parameters to createZeroValued #41

@coderabbitai

Description

@coderabbitai

Problem

The liveMap factory method in Tests/AblyLiveObjectsTests/Helpers/TestFactories.swift calls InternalDefaultLiveMap.createZeroValued() without the required parameters.

Current Code (lines 175-183)

static func liveMap(
    objectId: String = "map:test@123",
    entries: [String: String] = [:]
) -> InternalDefaultLiveMap {
    let map = InternalDefaultLiveMap.createZeroValued()
    // Configure map with entries...
    return map
}

Expected Fix

The method should pass the required objectID and logger parameters:

let map = InternalDefaultLiveMap.createZeroValued(
    objectID: objectId,
    logger: /* provide a test logger here */
)

Context

This issue was identified during review of PR #26 but predates that PR.

References:

┆Issue is synchronized with this Jira Task by Unito

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions