Suggestion to copy whole line instead of line contents

[flg]

Hello,

Thanks for this plugin. It's nice to have this feature available in the Eclipse Marketplace.

I understand it can be more of a personal preference thing but maybe this is a opportunity for user config. At the moment : CTRL+C copies the line contents without leading spaces and final return carriage, whereas CTRL+X removes the whole line. Wouldn't it make more sense to have it consistent and CTRL+C copying the whole line? I used to CTRL+C,CTRL+V to duplicate a line which does not work exactly now.

Thanks

[achimmihca]

I agree, though I never used the copy line feature.
If you take a look at CopyLineOrSelectedTextHandler.copyLine you will see that it is implemented as "move caret to start of line; select till end of line; copy selected text". Now in Eclipe if I rember correct, the first time "move caret to start of line" (aka the home button on the keyboard) is performed, it moves it to the first non-indentation character. The second time it is performed, it moves it to the very beginning of the line.
Thus, you might get the desired behaviour if you add another call to handlerService.executeCommand( "org.eclipse.ui.edit.text.goto.lineStart", null ); below the first one.

I don't use Eclipse anymore and I am not motivated to do this change.
However, it should be fairly easy and if you provide the necessary change in a pull request with built update-site (see docu), then I will gladly accept it and merge. The update-site in the Eclipse Marketplace would then also be updated.