Merge pull request #2124 from akashchi/reject-on-download-failure

danwkennedy · web-flow · commit 714f93aedcd8 · 2025-09-25T09:06:20.000-04:00
[ARTIFACT] Reject download promise if timeout was reached
diff --git a/packages/artifact/src/internal/download/download-artifact.ts b/packages/artifact/src/internal/download/download-artifact.ts
@@ -79,9 +79,11 @@ export async function streamExtractExternal(
 
   return new Promise((resolve, reject) => {
     const timerFn = (): void => {
-      response.message.destroy(
-        new Error(`Blob storage chunk did not respond in ${timeout}ms`)
+      const timeoutError = new Error(
+        `Blob storage chunk did not respond in ${timeout}ms`
       )
+      response.message.destroy(timeoutError)
+      reject(timeoutError)
     }
     const timer = setTimeout(timerFn, timeout)
 

Original file line number	Diff line number	Diff line change
`@@ -79,9 +79,11 @@ export async function streamExtractExternal(`
`79`	`79`
`80`	`80`	`return new Promise((resolve, reject) => {`
`81`	`81`	`const timerFn = (): void => {`
`82`		`- response.message.destroy(`
`83`		- new Error(`Blob storage chunk did not respond in ${timeout}ms`)
	`82`	`+ const timeoutError = new Error(`
	`83`	+ `Blob storage chunk did not respond in ${timeout}ms`
`84`	`84`	`)`
	`85`	`+ response.message.destroy(timeoutError)`
	`86`	`+ reject(timeoutError)`
`85`	`87`	`}`
`86`	`88`	`const timer = setTimeout(timerFn, timeout)`
`87`	`89`