fix(observables): avoid circular stringify

related: #22

Author: adriancarriger

package.json

@@ -35,6 +35,7 @@
   "typings": "index.d.ts",
   "homepage": "https://github.com/adriancarriger/angularfire2-offline",
   "dependencies": {
+    "json-stringify-safe": "^5.0.1",
     "localforage": "1.5.0"
   },
   "peerDependencies": {

src/afo-list-observable.ts

@@ -3,6 +3,7 @@ import { ReplaySubject } from 'rxjs';
 import { unwrap } from './database';
 import { OfflineWrite } from './offline-write';
 import { LocalUpdateService } from './local-update-service';
+const stringify = require('json-stringify-safe');
 
 export class AfoListObservable<T> extends ReplaySubject<T> {
   /**
@@ -14,6 +15,10 @@ export class AfoListObservable<T> extends ReplaySubject<T> {
    * in {@link value} before being applied
    */
   que = [];
+  /**
+   * Number of times updated
+   */
+  updated: number;
   /**
    * The current value of the {@link AfoListObservable}
    */
@@ -71,9 +76,10 @@ export class AfoListObservable<T> extends ReplaySubject<T> {
    * Only calls next if the new value is unique
    */
   uniqueNext(newValue) {
-    if (JSON.stringify(this.previousValue) !== JSON.stringify(newValue) ) {
+    if (this.updated > 1 || (stringify(this.previousValue) !== stringify(newValue)) ) {
       this.previousValue = newValue;
       this.next(newValue);
+      this.updated++;
     }
   }
   /**

src/afo-object-observable.ts

@@ -3,6 +3,7 @@ import { ReplaySubject } from 'rxjs';
 import { unwrap } from './database';
 import { OfflineWrite } from './offline-write';
 import { LocalUpdateService } from './local-update-service';
+const stringify = require('json-stringify-safe');
 
 export class AfoObjectObservable<T> extends ReplaySubject<T> {
   /**
@@ -14,6 +15,10 @@ export class AfoObjectObservable<T> extends ReplaySubject<T> {
    * in {@link value} before being applied
    */
   que = [];
+  /**
+   * Number of times updated
+   */
+  updated: number;
   /**
    * The current value of the {@link AfoObjectObservable}
    */
@@ -114,9 +119,10 @@ export class AfoObjectObservable<T> extends ReplaySubject<T> {
    * Only calls next if the new value is unique
    */
   uniqueNext(newValue) {
-    if (JSON.stringify(this.previousValue) !== JSON.stringify(newValue) ) {
+    if (this.updated > 1 || (stringify(this.previousValue) !== stringify(newValue) )) {
       this.previousValue = newValue;
       this.next(newValue);
+      this.updated++;
     }
   }
   /**

yarn.lock

@@ -2101,7 +2101,7 @@ json-stable-stringify@^1.0.1:
   dependencies:
     jsonify "~0.0.0"
 
-json-stringify-safe@~5.0.1:
+json-stringify-safe@^5.0.1, json-stringify-safe@~5.0.1:
   version "5.0.1"
   resolved "https://registry.yarnpkg.com/json-stringify-safe/-/json-stringify-safe-5.0.1.tgz#1296a2d58fd45f19a0f6ce01d65701e2c735b6eb"
 
@@ -3433,15 +3433,15 @@ right-pad@^1.0.1:
   version "1.0.1"
   resolved "https://registry.yarnpkg.com/right-pad/-/right-pad-1.0.1.tgz#8ca08c2cbb5b55e74dafa96bf7fd1a27d568c8d0"
 
-rimraf@2, rimraf@^2.3.3, rimraf@^2.4.4, rimraf@~2.5.1, rimraf@~2.5.4:
-  version "2.5.4"
-  resolved "https://registry.yarnpkg.com/rimraf/-/rimraf-2.5.4.tgz#96800093cbf1a0c86bd95b4625467535c29dfa04"
+rimraf@2, rimraf@^2.3.3, rimraf@^2.4.4, rimraf@^2.6.1:
+  version "2.6.1"
+  resolved "https://registry.yarnpkg.com/rimraf/-/rimraf-2.6.1.tgz#c2338ec643df7a1b7fe5c54fa86f57428a55f33d"
   dependencies:
     glob "^7.0.5"
 
-rimraf@^2.6.1:
-  version "2.6.1"
-  resolved "https://registry.yarnpkg.com/rimraf/-/rimraf-2.6.1.tgz#c2338ec643df7a1b7fe5c54fa86f57428a55f33d"
+rimraf@~2.5.1, rimraf@~2.5.4:
+  version "2.5.4"
+  resolved "https://registry.yarnpkg.com/rimraf/-/rimraf-2.5.4.tgz#96800093cbf1a0c86bd95b4625467535c29dfa04"
   dependencies:
     glob "^7.0.5"