feature/move-inscription-page-to-sf : Fix les tests en factorisant la conversion des messages flash legacy au nouveua format des messages flash

Author: Raphael

sources/AppBundle/Controller/Admin/Event/ListAction.php

@@ -14,14 +14,6 @@ public function __construct(private readonly EventRepository $eventRepository) {
 
     public function __invoke(): Response
     {
-        //TODO : à supprimer quand les actions via le formulaire auront été migée
-        if (isset($_SESSION['flash']['message'])) {
-            $this->addFlash('notice', $_SESSION['flash']['message']);
-        }
-        if (isset($_SESSION['flash']['erreur'])) {
-            $this->addFlash('error', $_SESSION['flash']['erreur']);
-        }
-        unset($_SESSION['flash']);
         $list = $this->eventRepository->getList();
         return $this->render('admin/event/list.html.twig', [
             'events' => $list,

sources/AppBundle/Controller/LegacyController.php

@@ -76,14 +76,6 @@ public function backOffice()
         // Initialisation de AFUP_Log
         Logs::initialiser($bdd, $droits->obtenirIdentifiant());
         require_once __DIR__ . '/../../../htdocs/pages/administration/' . $_GET['page'] . '.php';
-        // On gère des infos popups
-        if (isset($_SESSION['flash']['message'])) {
-            $this->addFlash('notice', $_SESSION['flash']['message']);
-        }
-        if (isset($_SESSION['flash']['erreur'])) {
-            $this->addFlash('error', $_SESSION['flash']['erreur']);
-        }
-        unset($_SESSION['flash']);
         // Récupération du contenu de la page généré par smarty
         $content = $smarty->fetch($_GET['page'] . '.html');
 

sources/AppBundle/Listener/ConvertLegacyFlashMessageKernelListener.php

@@ -0,0 +1,39 @@
+<?php
+
+declare(strict_types=1);
+
+namespace AppBundle\Listener;
+
+use Symfony\Component\EventDispatcher\Attribute\AsEventListener;
+use Symfony\Component\HttpFoundation\Exception\SessionNotFoundException;
+use Symfony\Component\HttpFoundation\RequestStack;
+use Symfony\Component\HttpFoundation\Session\FlashBagAwareSessionInterface;
+use Symfony\Component\HttpKernel\KernelEvents;
+
+//TODO : à supprimer quand les flash messages du legacy seront migrés
+#[AsEventListener(KernelEvents::REQUEST)]
+final readonly class ConvertLegacyFlashMessageKernelListener
+{
+    public function __construct(private RequestStack $requestStack) {}
+
+    public function onKernelRequest(): void
+    {
+        try {
+            $session = $this->requestStack->getSession();
+        } catch (SessionNotFoundException) {
+            return;
+        }
+
+        if (!$session instanceof FlashBagAwareSessionInterface) {
+            return;
+        }
+
+        if (isset($_SESSION['flash']['message'])) {
+            $session->getFlashBag()->add('notice', $_SESSION['flash']['message']);
+        }
+        if (isset($_SESSION['flash']['erreur'])) {
+            $session->getFlashBag()->add('error', $_SESSION['flash']['erreur']);
+        }
+        unset($_SESSION['flash']);
+    }
+}