feat: assign af:implemented label to issues when spec completes

[mickume]

Summary

When the orchestrator finishes all task groups for a spec that originated from a GitHub issue, it should apply the af:implemented label after posting the summary comment. The issue stays open for manual verification.

This was implemented in commit b3ddcfa9 but reverted to re-approach.

Scope of changes

1. Engine — post_issue_summaries (packages/agentfox/agentfox/engine/engine.py)

After successfully posting the summary comment to the source issue, the engine calls platform.assign_label() with the af:implemented label. On failure, it logs a warning but does not block — the spec is still recorded as posted. A continue was added after the existing comment-post error handler so the label assignment is skipped when commenting fails.

2. Label registry (packages/agentfox/agentfox/platform/labels.py)

• New constant: LABEL_IMPLEMENTED = "af:implemented"
• New LabelSpec entry in REQUIRED_LABELS with color #0969da and description "Spec implementation complete — awaiting manual verification"

3. Tests (packages/agentfox/tests/unit/engine/test_issue_summary.py)

• test_assigns_implemented_label_on_success — verifies assign_label is called with the correct issue number and label after a successful post.
• test_label_failure_does_not_block_posting — verifies that a RuntimeError from assign_label is caught, logged as a warning, and the spec still appears in the posted set.
• Existing test fixture _make_mock_platform updated to include assign_label = AsyncMock().

Files changed (3 files, +71 lines)

• packages/agentfox/agentfox/engine/engine.py (+14)
• packages/agentfox/agentfox/platform/labels.py (+8)
• packages/agentfox/tests/unit/engine/test_issue_summary.py (+49)

[mickume]

Analysis

Auto-generated by af-fix. Reviewing issue context and codebase.

Diagnosis

Classification: feature

Problem:
When the orchestrator completes all task groups for a spec originating from a GitHub issue, it posts a summary comment but does not apply the af:implemented label. Users have no visual signal on the issue tracker that implementation is complete and awaiting manual verification.

Planned Fix

Approach:

1. Add LABEL_IMPLEMENTED = "af:implemented" constant and corresponding LabelSpec to labels.py
2. In post_issue_summaries() (engine.py), after successful add_issue_comment(), call platform.assign_label() with the implemented label. On failure, log a warning but don't block — the spec is still recorded as posted.
3. Add continue after the existing comment-post error handler so label assignment is skipped when commenting fails.
4. Add tests: successful label assignment and label failure handling.

Files to modify:

• packages/agentfox/agentfox/platform/labels.py — Add constant and LabelSpec
• packages/agentfox/agentfox/engine/engine.py — Add label assignment after comment posting
• packages/agentfox/tests/unit/engine/test_issue_summary.py — Add tests, update fixture

---

Analysis by af-fix. Implementation follows.

[mickume]

Fix Implemented

Auto-generated by af-fix.

Summary

Added LABEL_IMPLEMENTED = "af:implemented" constant and LabelSpec to the label registry. post_issue_summaries() now calls platform.assign_label() with af:implemented after successfully posting a summary comment. Label assignment failures are caught and logged as warnings without affecting the posted set. When commenting fails, the continue skips label assignment entirely.

Changes

File	Change
packages/agentfox/agentfox/platform/labels.py	Added LABEL_IMPLEMENTED constant and LabelSpec entry
packages/agentfox/agentfox/engine/engine.py	Added label assignment after comment posting with error handling
packages/agentfox/tests/unit/engine/test_issue_summary.py	Updated fixture, added 3 tests

Tests

• test_assigns_implemented_label_on_success: verifies assign_label called with correct args
• test_label_failure_does_not_block_posting: verifies label error is caught, spec still in posted set
• test_label_not_assigned_when_comment_fails: verifies label not called when comment fails

Verification

• All existing tests pass: ✅
• New tests pass: ✅
• Linter / formatter: ✅
• No regressions: ✅

Branch

feature/issue-636-implemented-label — ready to merge into main.

---

Fix by af-fix. Ready for review.