Rename skill afspec

[mickume]

Rename skill "afspec" to "af-spec" in order to follow the same pattern as the other skills do. No changes to the skill itself are expected, except for the name change.

[mickume]

Starting fix session on branch fix/637-rename-skill-afspec... (run: 20260626_144124_55220f)

[mickume]

Triage Report

Summary: The skill template file packages/agentfox/agentfox/_templates/skills/afspec is named afspec, which causes the installed skill directory to be .claude/skills/afspec/ with name: afspec in its frontmatter. All other bundled skills follow the hyphenated af-* convention (af-fix, af-clone-issue, af-code-simplifier, af-security-audit). The fix requires renaming the template file to af-spec and updating its name: frontmatter field, renaming the git-tracked installed skill directory, and updating the four test files that hardcode the old path, plus the two documentation files that reference the old skill name.

Affected files:

• packages/agentfox/agentfox/_templates/skills/afspec
• .claude/skills/afspec/SKILL.md
• packages/agentfox/tests/unit/templates/test_78_local_branches.py
• packages/agentfox/tests/property/templates/test_78_local_branches_props.py
• packages/agentfox/tests/spec/test_135_v12_skill_validation.py
• packages/agentfox/tests/integration/test_init_skills.py
• docs/skills.md
• docs/cli-reference.md

Acceptance Criteria

AC-1: The bundled skill template file is renamed to af-spec and its name: frontmatter reflects the new name.

• Preconditions: The file packages/agentfox/agentfox/_templates/skills/afspec exists with name: afspec in its YAML frontmatter.
• Expected: The file packages/agentfox/agentfox/_templates/skills/af-spec exists, packages/agentfox/agentfox/_templates/skills/afspec no longer exists, and the file's frontmatter contains name: af-spec.
• Assertion: Run ls packages/agentfox/agentfox/_templates/skills/ and assert af-spec is present and afspec is absent. Run head -3 packages/agentfox/agentfox/_templates/skills/af-spec and assert the name: field equals af-spec.

AC-2: Running af init --skills installs the skill as .claude/skills/af-spec/SKILL.md, not .claude/skills/afspec/SKILL.md.

• Preconditions: A temporary git repository exists with no existing .claude/skills/ directory. The template file is renamed to af-spec per AC-1.
• Expected: After af init --skills, the file .claude/skills/af-spec/SKILL.md exists and .claude/skills/afspec/SKILL.md does not exist.
• Assertion: The integration test packages/agentfox/tests/integration/test_init_skills.py::TestSkillsWorkOnReinit::test_skills_work_on_reinit asserts (tmp_git_repo / '.claude' / 'skills' / 'af-spec' / 'SKILL.md').exists() (update from afspec).

AC-3: The git-tracked installed skill at .claude/skills/afspec/ is renamed to .claude/skills/af-spec/ with updated frontmatter.

• Preconditions: .claude/skills/afspec/SKILL.md is tracked by git.
• Expected: .claude/skills/af-spec/SKILL.md is tracked by git, .claude/skills/afspec/ no longer exists, and the frontmatter name: field in the installed SKILL.md matches af-spec.
• Assertion: Run git ls-files .claude/skills/ and assert af-spec/SKILL.md appears and afspec/SKILL.md does not.

AC-4: All test files that hardcode the template path _templates/skills/afspec are updated to _templates/skills/af-spec.

• Preconditions: Tests in test_78_local_branches.py, test_78_local_branches_props.py, test_135_v12_skill_validation.py, and test_init_skills.py reference the path ending in afspec.
• Expected: Each of those four files references the path ending in af-spec instead of afspec, and the template path constants resolve to an existing file.
• Assertion: Run grep -rn 'skills.*afspec' packages/agentfox/tests/ and assert zero matches. Run make test and assert no test failures in those four files.

AC-5: Documentation is updated to use af-spec as the skill name.

• Preconditions: docs/skills.md has a section heading ## afspec and docs/cli-reference.md references the example /afspec.
• Expected: docs/skills.md uses ## af-spec and docs/cli-reference.md uses /af-spec as the example slash command.
• Assertion: Run grep 'afspec' docs/skills.md docs/cli-reference.md and assert the only remaining occurrences (if any) refer to the afspec Python library, not the skill name.

(run: 20260626_144124_55220f)

[mickume]

Fix Review Report

Overall verdict: PASS

Summary: All 5 acceptance criteria pass. The rename from afspec to af-spec is correctly applied across: the bundled template file and its frontmatter, the git-tracked installed skill directory, all four test files, and both documentation files. All 35 tests in the affected files pass. The 4 lint errors in make check are pre-existing in files not touched by this commit.

Per-criterion verdicts

• ✅ NS-REQ-1.1: PASS
  • Evidence: The file packages/agentfox/agentfox/_templates/skills/af-spec exists with name: af-spec in its frontmatter. The old file packages/agentfox/agentfox/_templates/skills/afspec no longer exists. Verified via ls and head -5.
• ✅ NS-REQ-2.1: PASS
  • Evidence: The integration test test_init_skills.py was updated to reference af-spec instead of afspec. All 35 tests in the four affected test files pass, including test_init_skills.py which asserts the installed path uses af-spec/SKILL.md.
• ✅ NS-REQ-3.1: PASS
  • Evidence: git ls-files .claude/skills/ shows .claude/skills/af-spec/SKILL.md is tracked. .claude/skills/afspec/ no longer exists. The installed SKILL.md frontmatter contains name: af-spec.
• ✅ NS-REQ-4.1: PASS
  • Evidence: grep -rn 'skills.*afspec' packages/agentfox/tests/ returns zero matches. All four test files (test_78_local_branches.py, test_78_local_branches_props.py, test_135_v12_skill_validation.py, test_init_skills.py) reference af-spec and pass (35/35 tests pass).
• ✅ NS-REQ-5.1: PASS
  • Evidence: docs/skills.md uses ## af-spec (line 22). docs/cli-reference.md uses /af-spec (line 130). The only remaining afspec occurrence in docs/skills.md (line 58) refers to the afspec Python library (backtick-quoted), not the skill name.

(run: 20260626_144124_55220f)

[mickume]

Fix complete on branch fix/637-rename-skill-afspec. Changes have been merged into main. (run: 20260626_144124_55220f)