From 35da4cb5e28e22a5b1fb40337257503c80dc2c94 Mon Sep 17 00:00:00 2001 From: xiatg Date: Thu, 28 May 2026 15:45:55 -0400 Subject: [PATCH] Revert "fix: explicitly pass model provider on session resume (#139)" This reverts commit 5e99c284796e02537202a3e6b2bc88a3ddf3a051. --- src/CodexAcpClient.ts | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/src/CodexAcpClient.ts b/src/CodexAcpClient.ts index 22cde0d..e8ab397 100644 --- a/src/CodexAcpClient.ts +++ b/src/CodexAcpClient.ts @@ -205,7 +205,7 @@ export class CodexAcpClient { const response = await this.codexClient.threadResume({ config: await this.createSessionConfig(request.cwd, request.mcpServers ?? []), cwd: request.cwd, - modelProvider: this.getResumeModelProvider(), + modelProvider: this.getModelProvider(), threadId: request.sessionId, }); const codexModels = await this.fetchAvailableModels(); @@ -222,7 +222,7 @@ export class CodexAcpClient { const response = await this.codexClient.threadResume({ config: await this.createSessionConfig(request.cwd, request.mcpServers ?? []), cwd: request.cwd, - modelProvider: this.getResumeModelProvider(), + modelProvider: this.getModelProvider(), threadId: request.sessionId, }); const codexModels = await this.fetchAvailableModels(); @@ -306,12 +306,6 @@ export class CodexAcpClient { return this.gatewayConfig?.modelProvider ?? this.modelProvider; } - private getResumeModelProvider(): string { - // Passing `null` forces codex to use the persisted provider for resumed session instead of default one - // Explicit fallback to "openai" fixes error `Model provider not found` at least for ChatGPT authentication - return this.getModelProvider() ?? "openai"; - } - private async refreshSkills(cwd: string, meta?: Record | null): Promise { if (!cwd) { return;