Skip to content
This repository was archived by the owner on Oct 16, 2024. It is now read-only.

Commit 019fdf2

Browse files
committed
configured babel correctly
1 parent 9400e0e commit 019fdf2

File tree

3 files changed

+494
-16
lines changed

3 files changed

+494
-16
lines changed

package.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,9 @@
4747
"url": "git+https://github.com/agile-ts/agile.git"
4848
},
4949
"devDependencies": {
50+
"@babel/cli": "^7.15.7",
51+
"@babel/core": "^7.15.5",
52+
"@babel/preset-env": "^7.15.6",
5053
"@changesets/cli": "^2.16.0",
5154
"@rollup/plugin-babel": "^5.3.0",
5255
"@rollup/plugin-node-resolve": "^13.0.4",

packages/rollup.config.default.js

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,19 +8,17 @@ import esbuild from 'rollup-plugin-esbuild';
88
import typescript from '@rollup/plugin-typescript';
99
import bundleSize from 'rollup-plugin-bundle-size';
1010

11-
export const fileExtensions = ['.js', '.ts', '.tsx'];
11+
export const fileExtensions = ['.ts'];
1212

1313
export function createEsbuildConfig(config) {
1414
config = {
1515
target: 'es2015',
16-
tsconfig: path.resolve('./tsconfig.json'),
1716
additionalOptions: {},
1817
...config,
1918
};
2019
return esbuild({
2120
minify: false,
2221
target: config.target,
23-
tsconfig: config.tsconfig,
2422
...config.additionalOptions,
2523
});
2624
}
@@ -73,8 +71,9 @@ export function createESMConfig(config) {
7371
external: config.external,
7472
plugins: [
7573
nodeResolve({ extensions: fileExtensions }),
76-
createEsbuildConfig({ target: 'es2015', tsconfig: config.tsconfig }),
77-
// typescript(), // Not required because the 'esbuild-config' does configure typescript for us
74+
createEsbuildConfig({ target: 'es2015' }),
75+
// typescript(), // Not required because esbuild takes care of configuring typescript
76+
// babel(/* */), // Not required because esbuild takes care of converting ES2015+ modules into compatible JavaScript files
7877
!config.multiFileOutput && bundleSize(),
7978
...config.additionalPlugins,
8079
],
@@ -96,15 +95,22 @@ export function createCommonJSConfig(config) {
9695

9796
return defineConfig({
9897
input: config.input,
99-
output: { file: config.output, format: 'cjs' },
98+
output: {
99+
file: config.output,
100+
format: 'cjs',
101+
},
100102
external: config.external,
101103
plugins: [
102104
nodeResolve({ extensions: fileExtensions }),
105+
// https://github.com/rollup/plugins/tree/master/packages/babel#running-babel-on-the-generated-code
103106
babel({
104107
babelHelpers: 'bundled',
105108
comments: false,
109+
exclude: ['node_modules/**'],
110+
presets: ['@babel/preset-env'],
111+
extensions: fileExtensions, // https://github.com/rollup/rollup-plugin-babel/issues/255
106112
}),
107-
typescript({ tsconfig: config.tsconfig }),
113+
typescript(), // Only so that Rollup can work with typescript (Not for generating any 'declaration' files)
108114
bundleSize(),
109115
...config.additionalPlugins,
110116
],

0 commit comments

Comments
 (0)