코드 수정

Author: ahastudio

20230325/express/src/services/ProductService.ts

@@ -171,8 +171,6 @@ export default class ProductService {
     }));
     product.description = productDto.description;
     product.hidden = !!product.hidden;
-
-    data.products.push(product);
   }
 }
 

20230423/react/src/components/Header.tsx

@@ -9,21 +9,19 @@ import useAccessToken from '../hooks/useAccessToken';
 import { apiService } from '../services/ApiService';
 
 const Container = styled.header`
-  margin-bottom: 2rem;
+  margin-bottom: 1rem;
 
   h1 {
-    font-size: 4rem;
+    font-size: 3rem;
   }
 
-  nav {
-    padding-block: 2rem;
-
-    ul {
-      display: flex;
-    }
+  ul {
+    display: flex;
 
     li {
-      margin-right: 2rem;
+      height: 4rem;
+      line-height: 4rem;
+      margin-right: 1rem;
     }
   }
 `;

20230423/react/src/constants.ts

@@ -1,9 +1,10 @@
-/* eslint-disable import/prefer-default-export */
-
 export const STATUS_MESSAGES: Record<string, string> = {
   paid: '결제 완료',
   ready: '배송 준비',
   shipping: '배송 중',
   complete: '배송 완료',
   canceled: '취소',
 };
+
+// TODO: delete this!
+export default {};

20230423/react/src/hooks/useFetchCategories.ts

@@ -5,11 +5,13 @@ import { apiService } from '../services/ApiService';
 import { Category } from '../types';
 
 export default function useFetchCategories() {
+  type Data = {
+    categories: Category[];
+  };
+
   const {
     data, error, loading, mutate,
-  } = useFetch<{
-    categories: Category[];
-  }>('/categories');
+  } = useFetch<Data>('/categories');
 
   return {
     categories: data?.categories ?? [],

20230423/react/src/hooks/useFetchUsers.ts

@@ -3,9 +3,11 @@ import useFetch from './useFetch';
 import { User } from '../types';
 
 export default function useFetchUsers() {
-  const { data, error, loading } = useFetch<{
+  type Data = {
     users: User[];
-  }>('/users');
+  };
+
+  const { data, error, loading } = useFetch<Data>('/users');
 
   return {
     users: data?.users ?? [],

20230423/react/src/pages/OrderDetailPage.tsx

@@ -47,7 +47,7 @@ const Container = styled.div`
   }
 `;
 
-export default function OrderEditPage() {
+export default function OrderDetailPage() {
   const params = useParams();
 
   const { order, loading, error } = useFetchOrder({
@@ -129,9 +129,17 @@ export default function OrderEditPage() {
         <dt>상태</dt>
         <dd>{STATUS_MESSAGES[order.status]}</dd>
       </dl>
-      <Link to={`/orders/${order.id}/edit`}>
-        상태 변경
-      </Link>
+      <p>
+        <Link to={`/orders/${order.id}/edit`}>
+          상태 변경
+        </Link>
+        {' '}
+        |
+        {' '}
+        <Link to="/orders">
+          주문 목록
+        </Link>
+      </p>
     </Container>
   );
 }

20230423/react/src/pages/OrderListPage.tsx

@@ -58,7 +58,7 @@ export default function OrderListPage() {
 
   return (
     <Container>
-      <h2>Products</h2>
+      <h2>Orders</h2>
       <table>
         <thead>
           <tr>

20230423/react/src/routes.test.tsx

@@ -166,16 +166,16 @@ describe('routes', () => {
       });
     });
 
-    // context('when the current path is “/products/{id}/edit', () => {
-    //   const [product] = fixtures.products;
+    context('when the current path is “/products/{id}/edit', () => {
+      const [product] = fixtures.products;
 
-    //   it('renders the edit product page', async () => {
-    //     renderRouter(`/products/${product.id}/edit`);
+      it('renders the edit product page', async () => {
+        renderRouter(`/products/${product.id}/edit`);
 
-    //     await waitFor(() => {
-    //       screen.getByDisplayValue(product.name);
-    //     });
-    //   });
-    // });
+        await waitFor(() => {
+          screen.getByDisplayValue(product.name);
+        });
+      });
+    });
   });
 });

20230423/react/src/stores/ProductFormStore.test.ts

@@ -45,6 +45,8 @@ describe('ProductFormStore', () => {
     beforeEach(() => {
       store.reset();
 
+      expect(store.valid).toBeFalsy();
+
       store.changeCategory(category);
       store.changeName('New Product');
       store.changePrice('123400');