Integer divide error in dm.py #96
Description
When creating the DM surface in dm.py, there is a bug that is copied over from an old version of Python PROPER (<v3.1 from 2019). What should be an integer divide is a float divide. The bug occurs in lines 390 and 1223. The buggy line is:
xoff_grid = margin + inf_mag/2 # pixel location of 1st actuator center in subsampled grid
The fix is to replace inf_mag/2 with inf_mag//2.
This was causing a 0.25 pixel shift error in X and Y between DM surface maps created in FALCO and those with the current version of PROPER. Small in terms of actuator centering error, but enough to create a notable difference between the compact and PROPER full model results.
Also, the version of PROPER distributed with FALCO should be removed and users instructed to install the current version of PROPER from Sourceforge.