Coding style fixes to match with M2EQP

Author: Florian Horn

Model/Configuration.php

@@ -214,4 +214,4 @@ public function setDummyContentEmail($dummyContentEmail)
         $this->dummyContentEmail = $dummyContentEmail;
         return $this;
     }
-}
+}

Observer/CategoriesObserver.php

@@ -51,6 +51,9 @@ public function execute(\Magento\Framework\Event\Observer $observer)
             return;
         }
 
+        // @TODO clear table url_rewrite for entity_type category
+        // @TODO mark indexer to invalidate index
+
         /** @var CategoryResource $categoryResource */
         $categoryResource = $this->categoryResourceFactory->create();
 

Observer/ProductsObserver.php

@@ -74,7 +74,8 @@ protected function updateData(Configuration $configuration, \Magento\Catalog\Mod
         if (!$configuration->isUseOnlyEmpty() ||
             ($configuration->isUseOnlyEmpty() && empty($product->getDescription()))) {
             $product->setDescription($configuration->getDummyContentText());
-        }if (!$configuration->isUseOnlyEmpty() ||
+        }
+        if (!$configuration->isUseOnlyEmpty() ||
             ($configuration->isUseOnlyEmpty() && empty($product->getShortDescription()))) {
             $product->setShortDescription($configuration->getDummyContentText());
         }

Test/Unit/Console/Command/FuzzyfyrCommandTest.php

@@ -58,4 +58,4 @@ public function testExecuteError()
         $commandTester = new CommandTester($this->command);
         $commandTester->execute([]);
     }
-}
+}

build.sh

@@ -345,6 +345,7 @@ fi
 
 CURDIR=$(pwd)
 SRC=${arg_s:-"${CURDIR}"}
+EQP=${arg_t:-"${CURDIR}/build/eqp"}
 TMP=${arg_t:-"${CURDIR}/build/tmp"}
 DEST=${arg_d:-"${CURDIR}/build/store"}
 OUTPUT="${DEST}/allindata_contentfuzzyfyr.zip"
@@ -358,6 +359,10 @@ fi
 if [ ! -d "${TMP}" ]; then
     mkdir -p "${TMP}"
 fi
+if [ ! -d "${EQP}" ]; then
+    mkdir -p "${EQP}"
+    composer create-project --repository=https://repo.magento.com magento/marketplace-eqp "${EQP}"
+fi
 rm -rf "${TMP}"/*
 if [ ! -d "${DEST}" ]; then
     mkdir -p "${DEST}"
@@ -368,7 +373,7 @@ rm -rf "${DEST}"/*
 ## Update dependencies
 ## Based upon  PHP 7.0
 ##
-docker run -v "${SRC}":/www -v ~/.composer:/root/.composer danieldent/php-7.0-composer:latest bash -c 'apt-get install -y libfreetype6-dev libjpeg62-turbo-dev libmcrypt-dev libpng12-dev libxslt-dev && docker-php-ext-configure gd --with-freetype-dir=/usr/include/ --with-jpeg-dir=/usr/include/ && docker-php-ext-install gd mcrypt xsl && cd /www && composer update'
+docker run -v "${SRC}":/www -v ~/.composer:/root/.composer --rm danieldent/php-7.1-composer:latest bash -c 'apt-get install -y libfreetype6-dev libjpeg62-turbo-dev libmcrypt-dev libpng12-dev libxslt-dev && docker-php-ext-configure gd --with-freetype-dir=/usr/include/ --with-jpeg-dir=/usr/include/ && docker-php-ext-install gd mcrypt xsl && cd /www && composer update'
 
 ##
 ## Prepare important files
@@ -388,6 +393,11 @@ cp -pP "${SRC}/phpunit.xml" "${TMP}/phpunit.xml"
 cp -pP "${SRC}/README.md" "${TMP}/README.md"
 cp -pP "${SRC}/registration.php" "${TMP}/registration.php"
 
+##
+## Validation for M2EQB
+##
+docker run -v "${TMP}":/www -v "${EQP}":/m2eqb -v ~/.composer:/root/.composer --rm danieldent/php-7.1-composer:latest bash -c 'cd /m2eqb && vendor/bin/phpcs /www --standard=MEQP2 --severity=10 --extensions=php,phtml'
+
 ##
 ## Build package
 ##

composer.lock

@@ -17,7 +17,6 @@ services:
       - ./Observer:/var/www/html/app/code/AllInData/ContentFuzzyfyr/Observer:cached
       - ./Test:/var/www/html/app/code/AllInData/ContentFuzzyfyr/Test:cached
       - ./registration.php:/var/www/html/app/code/AllInData/ContentFuzzyfyr/registration.php
-      - ./var:/var/www/html/var
     ports:
       - 8000:80
     networks: &appnetworks