Remove crypto and FX endpoints for Alpha Vantage

Author: ttt733

alpaca_trade_api/alpha_vantage/rest.py

@@ -128,112 +128,6 @@ def search_endpoint(self, keywords, datatype='json'):
                   'keywords': keywords, 'datatype': datatype}
         return self.get(params)
 
-    def historic_fx_quotes(
-        self, from_symbol, to_symbol, outputsize='full',
-        cadence='daily', output_format=None
-    ):
-        ''' Returns one of the FX_* endpoints of the Alpha Vantage API.
-
-        Params:
-            from_currency: The symbol to convert
-            to_currency: The symbol to convert to
-            cadence: Choose between ['daily', 'weekly', 'monthly']
-            output_format: Choose between['json', 'csv', 'pandas']
-
-        Returns:
-            pandas, csv, or json
-        '''
-        if output_format:
-            self._foreignexchange.output_format = output_format
-        if cadence == 'daily':
-            data, _ = self._foreignexchange.get_currency_exchange_daily(
-                from_symbol=from_symbol,
-                to_symbol=to_symbol,
-                outputsize=outputsize
-            )
-        if cadence == 'weekly':
-            data, _ = self._foreignexchange.get_currency_exchange_weekly(
-                from_symbol=from_symbol,
-                to_symbol=to_symbol,
-                outputsize=outputsize
-            )
-        if cadence == 'monthly':
-            data, _ = self._foreignexchange.get_currency_exchange_monthly(
-                from_symbol=from_symbol,
-                to_symbol=to_symbol,
-                outputsize=outputsize
-            )
-        return data
-
-    def intraday_fx_quotes(
-        self, from_symbol, to_symbol, interval='5min',
-        outputsize='full', output_format=None
-    ):
-        ''' Returns the FX_INTRADAY endpoint of the Alpha Vantage API.
-
-        Params:
-            from_currency: The symbol to convert
-            to_currency: The symbol to convert to
-            interval: Choose between['1min', '5min', '15min', '30min', '60min']
-            output_format: Choose between['json', 'csv', 'pandas']
-
-        Returns:
-            pandas, csv, or json
-        '''
-        if output_format:
-            self._foreignexchange.output_format = output_format
-        data, _ = self._foreignexchange.get_currency_exchange_intraday(
-            from_symbol=from_symbol,
-            to_symbol=to_symbol,
-            interval=interval,
-            outputsize=outputsize
-        )
-        return data
-
-    def exchange_rate(self, from_currency, to_currency):
-        ''' Returns the exchange rate of two currencies, digital or physical.
-        CURRENCY_EXCHANGE_RATE endpoint of the Alpha Vantage API
-
-        Params:
-            from_currency: The symbol to convert
-            to_currency: The symbol to convert to
-
-        Returns:
-            json
-        '''
-        params = {'function': "CURRENCY_EXCHANGE_RATE",
-                  'from_currency': from_currency, 'to_currency': to_currency}
-        data = self.get(params)
-        return data
-
-    def historic_cryptocurrency_quotes(
-        self, symbol, market, cadence='daily', output_format=None
-    ):
-        ''' Returns one of the DIGITAL_CURRENCY_* endpoints of the
-        Alpha Vantage API.
-
-        Params:
-            symbol: The cryptocurrency to return
-            market: The market it's being sold on
-            cadence: Choose between ['daily', 'weekly', 'monthly']
-            output_format: Choose between['json', 'csv', 'pandas']
-
-        Returns:
-            pandas, csv, or json
-        '''
-        if output_format:
-            self._cryptocurrencies.output_format = output_format
-        if cadence == 'daily':
-            data, _ = self._cryptocurrencies.get_digital_currency_daily(
-                symbol=symbol, market=market)
-        if cadence == 'weekly':
-            data, _ = self._cryptocurrencies.get_digital_currency_weekly(
-                symbol=symbol, market=market)
-        if cadence == 'monthly':
-            data, _ = self._cryptocurrencies.get_digital_currency_monthly(
-                symbol=symbol, market=market)
-        return data
-
     def techindicators(
         self, techindicator='SMA', output_format='json', **kwargs
     ):

tests/test_alpha_vantage/test_rest.py

@@ -272,58 +272,6 @@ def test_search_endpoint(self, mock_request):
             self.assertIsInstance(
                 data, dict, 'Result Data must be a dict')
 
-    @requests_mock.Mocker()
-    def test_historic_fx_quotes(self, mock_request):
-        """ Test that api call returns a json file as requested
-        """
-        cli = REST(TestAlphaVantage._API_KEY_TEST)
-        url = "https://www.alphavantage.co/query?function=FX_DAILY&from_symbol=USD&to_symbol=EUR&outputsize=full&apikey=test"
-        path_file = self.get_file_from_url("mock_foreign_exchange_historical")
-        with open(path_file) as f:
-            mock_request.get(url, text=f.read())
-            data = cli.historic_fx_quotes('USD', 'EUR')
-            self.assertIsInstance(
-                data, dict, 'Result Data must be a dict')
-
-    @requests_mock.Mocker()
-    def test_intraday_fx_quotes(self, mock_request):
-        """ Test that api call returns a json file as requested
-        """
-        cli = REST(TestAlphaVantage._API_KEY_TEST)
-        url = "https://www.alphavantage.co/query?function=FX_INTRADAY&from_symbol=USD&to_symbol=EUR&outputsize=full&apikey=test"
-        path_file = self.get_file_from_url("mock_intraday_fx")
-        with open(path_file) as f:
-            mock_request.get(url, text=f.read())
-            data = cli.intraday_fx_quotes('USD', 'EUR')
-            self.assertIsInstance(
-                data, dict, 'Result Data must be a dict')
-
-    @requests_mock.Mocker()
-    def test_exchange_rate(self, mock_request):
-        """ Test that api call returns a json file as requested
-        """
-        cli = REST(TestAlphaVantage._API_KEY_TEST)
-        url = "https://www.alphavantage.co/query?function=CURRENCY_EXCHANGE_RATE&from_currency=USD&to_currency=EUR&apikey=test"
-        path_file = self.get_file_from_url("mock_foreign_exchange")
-        with open(path_file) as f:
-            mock_request.get(url, text=f.read())
-            data = cli.exchange_rate('USD', 'EUR')
-            self.assertIsInstance(
-                data, dict, 'Result Data must be a dict')
-
-    @requests_mock.Mocker()
-    def test_historic_cryptocurrency_quotes(self, mock_request):
-        """ Test that api call returns a json file as requested
-        """
-        cli = REST(TestAlphaVantage._API_KEY_TEST)
-        url = "https://www.alphavantage.co/query?function=DIGITAL_CURRENCY_DAILY&symbol=BTC&market=CNY&apikey=test&datatype=json"
-        path_file = self.get_file_from_url("mock_crypto_currencies")
-        with open(path_file) as f:
-            mock_request.get(url, text=f.read())
-            data = cli.historic_cryptocurrency_quotes('BTC', 'CNY')
-            self.assertIsInstance(
-                data, dict, 'Result Data must be a dict')
-
     @requests_mock.Mocker()
     def test_techindicators(self, mock_request):
         """ Test that api call returns a json file as requested