Skip to content

Commit 28fa996

Browse files
authored
Merge pull request #13 from alphagov/add-dependabot-pr-info
Add information about reviewing Dependabot PRs
2 parents 5f7a13f + 707738f commit 28fa996

File tree

1 file changed

+10
-0
lines changed

1 file changed

+10
-0
lines changed

development/code-reviews.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,3 +60,13 @@ GitHub’s ‘update branch’ button does)
6060

6161
Update the relevant Trello ticket for the PM to review the change (or should
6262
this happen before the merge?)
63+
64+
## When you review a Dependabot PR
65+
66+
To make sure the pull request works correctly:
67+
68+
- Read the release notes for the new version and look for changes that would impact our codebase. This is especially important with major releases.
69+
- Look at where in our codebase the package is used with `npm ls` - [see this example, where tests, Rollup and linting used the updated package](https://github.com/alphagov/govuk-design-system/pull/1813#issuecomment-896654240). Test that the parts of the codebase using the package work correctly.
70+
- If the new version is a major release, consider waiting for a few days before updating to see if anyone reports issues that could impact us.
71+
72+
After the first developer to review the pull request approves it, they should ask another developer for a review. The second developer can then approve the pull request, before merging it themselves.

0 commit comments

Comments
 (0)