From 52f1a0b26006510e5d99dcee43105d9e5aaf1c8d Mon Sep 17 00:00:00 2001 From: Rhisiart ap Gwilym Date: Sat, 6 Aug 2022 01:00:43 +0100 Subject: [PATCH 1/7] Update pubspec.yaml --- pubspec.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pubspec.yaml b/pubspec.yaml index c147afe..aab33af 100644 --- a/pubspec.yaml +++ b/pubspec.yaml @@ -19,8 +19,8 @@ dependencies: args: ^2.1.0 lcov: git: - url: git@github.com:amondnet/lcov.dart.git - + url: https://github.com/csells/lcov.dart.git + ref: 4319102 dev_dependencies: flutter_test: From a72f6a652d71f4cbceb59b450cb8bc43df30a724 Mon Sep 17 00:00:00 2001 From: Rhisiart ap Gwilym Date: Sat, 6 Aug 2022 01:07:48 +0100 Subject: [PATCH 2/7] Revert "Update pubspec.yaml" This reverts commit 52f1a0b26006510e5d99dcee43105d9e5aaf1c8d. --- pubspec.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pubspec.yaml b/pubspec.yaml index aab33af..c147afe 100644 --- a/pubspec.yaml +++ b/pubspec.yaml @@ -19,8 +19,8 @@ dependencies: args: ^2.1.0 lcov: git: - url: https://github.com/csells/lcov.dart.git - ref: 4319102 + url: git@github.com:amondnet/lcov.dart.git + dev_dependencies: flutter_test: From 5425c267dcd864d04e1d5e4cb096b408d0d5f010 Mon Sep 17 00:00:00 2001 From: Rhisiart ap Gwilym Date: Sat, 6 Aug 2022 01:10:24 +0100 Subject: [PATCH 3/7] Add publish_to: none as can't reference git in publishable packages --- pubspec.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/pubspec.yaml b/pubspec.yaml index c147afe..bfdde38 100644 --- a/pubspec.yaml +++ b/pubspec.yaml @@ -3,6 +3,7 @@ description: Flutter Coverage Badge version: 0.0.1+1 author: Minsu Lee homepage: https://github.com/amondnet/flutter_coverage_badge +publish_to: none environment: sdk: '>=2.12.0 <3.0.0' From 37c56015cae3120c214eb1db9602998902936f9b Mon Sep 17 00:00:00 2001 From: Rhisiart ap Gwilym Date: Sat, 6 Aug 2022 01:10:51 +0100 Subject: [PATCH 4/7] Delete pubspec.lock - not required for libraries --- pubspec.lock | 191 --------------------------------------------------- 1 file changed, 191 deletions(-) delete mode 100644 pubspec.lock diff --git a/pubspec.lock b/pubspec.lock deleted file mode 100644 index 60c5d99..0000000 --- a/pubspec.lock +++ /dev/null @@ -1,191 +0,0 @@ -# Generated by pub -# See https://dart.dev/tools/pub/glossary#lockfile -packages: - args: - dependency: "direct main" - description: - name: args - url: "https://pub.dartlang.org" - source: hosted - version: "2.1.0" - async: - dependency: transitive - description: - name: async - url: "https://pub.dartlang.org" - source: hosted - version: "2.6.1" - boolean_selector: - dependency: transitive - description: - name: boolean_selector - url: "https://pub.dartlang.org" - source: hosted - version: "2.1.0" - characters: - dependency: transitive - description: - name: characters - url: "https://pub.dartlang.org" - source: hosted - version: "1.1.0" - charcode: - dependency: transitive - description: - name: charcode - url: "https://pub.dartlang.org" - source: hosted - version: "1.2.0" - clock: - dependency: transitive - description: - name: clock - url: "https://pub.dartlang.org" - source: hosted - version: "1.1.0" - collection: - dependency: transitive - description: - name: collection - url: "https://pub.dartlang.org" - source: hosted - version: "1.15.0" - fake_async: - dependency: transitive - description: - name: fake_async - url: "https://pub.dartlang.org" - source: hosted - version: "1.2.0" - file: - dependency: transitive - description: - name: file - url: "https://pub.dartlang.org" - source: hosted - version: "6.1.1" - flutter: - dependency: "direct main" - description: flutter - source: sdk - version: "0.0.0" - flutter_test: - dependency: "direct dev" - description: flutter - source: sdk - version: "0.0.0" - glob: - dependency: "direct main" - description: - name: glob - url: "https://pub.dartlang.org" - source: hosted - version: "2.0.1" - json_annotation: - dependency: transitive - description: - name: json_annotation - url: "https://pub.dartlang.org" - source: hosted - version: "4.0.1" - lcov: - dependency: "direct main" - description: - path: "." - ref: HEAD - resolved-ref: "532be83f31b49fcad66884dee38ae1affe7c4319" - url: "git@github.com:amondnet/lcov.dart.git" - source: git - version: "6.0.0" - matcher: - dependency: transitive - description: - name: matcher - url: "https://pub.dartlang.org" - source: hosted - version: "0.12.10" - meta: - dependency: transitive - description: - name: meta - url: "https://pub.dartlang.org" - source: hosted - version: "1.3.0" - path: - dependency: "direct main" - description: - name: path - url: "https://pub.dartlang.org" - source: hosted - version: "1.8.0" - pedantic: - dependency: transitive - description: - name: pedantic - url: "https://pub.dartlang.org" - source: hosted - version: "1.11.0" - sky_engine: - dependency: transitive - description: flutter - source: sdk - version: "0.0.99" - source_span: - dependency: transitive - description: - name: source_span - url: "https://pub.dartlang.org" - source: hosted - version: "1.8.1" - stack_trace: - dependency: transitive - description: - name: stack_trace - url: "https://pub.dartlang.org" - source: hosted - version: "1.10.0" - stream_channel: - dependency: transitive - description: - name: stream_channel - url: "https://pub.dartlang.org" - source: hosted - version: "2.1.0" - string_scanner: - dependency: transitive - description: - name: string_scanner - url: "https://pub.dartlang.org" - source: hosted - version: "1.1.0" - term_glyph: - dependency: transitive - description: - name: term_glyph - url: "https://pub.dartlang.org" - source: hosted - version: "1.2.0" - test_api: - dependency: transitive - description: - name: test_api - url: "https://pub.dartlang.org" - source: hosted - version: "0.3.0" - typed_data: - dependency: transitive - description: - name: typed_data - url: "https://pub.dartlang.org" - source: hosted - version: "1.3.0" - vector_math: - dependency: transitive - description: - name: vector_math - url: "https://pub.dartlang.org" - source: hosted - version: "2.1.0" -sdks: - dart: ">=2.12.0 <3.0.0" - flutter: ">=2.0.0" From 5650053d63ffa4b43e3b2563cf95fec6a8cfcb6b Mon Sep 17 00:00:00 2001 From: Rhisiart ap Gwilym Date: Sat, 6 Aug 2022 01:11:08 +0100 Subject: [PATCH 5/7] Address lint issues --- lib/src/collector.dart | 2 -- pubspec.yaml | 1 - 2 files changed, 3 deletions(-) diff --git a/lib/src/collector.dart b/lib/src/collector.dart index fddc262..70d51c6 100644 --- a/lib/src/collector.dart +++ b/lib/src/collector.dart @@ -1,11 +1,9 @@ -import 'dart:convert'; import 'dart:io'; import 'package:lcov/lcov.dart'; import 'package:path/path.dart' as path; Future runTestsWithCoverage(String packageRoot) async { - final script = path.join(packageRoot); final flutterArgs = ['test', '--coverage', '']; final process = await Process.start('flutter', flutterArgs, diff --git a/pubspec.yaml b/pubspec.yaml index bfdde38..04ccabb 100644 --- a/pubspec.yaml +++ b/pubspec.yaml @@ -1,7 +1,6 @@ name: flutter_coverage_badge description: Flutter Coverage Badge version: 0.0.1+1 -author: Minsu Lee homepage: https://github.com/amondnet/flutter_coverage_badge publish_to: none From 89160d5542dc16925b879fa8e0f10ebf53e43024 Mon Sep 17 00:00:00 2001 From: Rhisiart ap Gwilym Date: Sat, 6 Aug 2022 01:18:52 +0100 Subject: [PATCH 6/7] Reference csells fork of lcov --- pubspec.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pubspec.yaml b/pubspec.yaml index 04ccabb..bfd0d15 100644 --- a/pubspec.yaml +++ b/pubspec.yaml @@ -19,7 +19,8 @@ dependencies: args: ^2.1.0 lcov: git: - url: git@github.com:amondnet/lcov.dart.git + url: https://github.com/csells/lcov.dart.git + ref: 4319102fa64eeba72fe8dfab024762e6253e3c93 dev_dependencies: From 4d6371f1bd46fee1bd28a697e303412839e53548 Mon Sep 17 00:00:00 2001 From: Rhisiart ap Gwilym Date: Sat, 6 Aug 2022 01:19:17 +0100 Subject: [PATCH 7/7] Ignore pubspec.lock --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 384f206..9bb8a7b 100644 --- a/.gitignore +++ b/.gitignore @@ -72,3 +72,4 @@ build/ !/packages/flutter_tools/test/data/dart_dependencies_test/**/.packages coverage +pubspec.lock \ No newline at end of file