move stuff into details namespace

Author: anderspkd

include/scl/hex.h

@@ -22,7 +22,7 @@
 #include <sstream>
 #include <string>
 
-namespace scl {
+namespace scl::details {
 
 /**
  * @brief Convert value into a string.
@@ -56,8 +56,6 @@ std::string toHexString(It begin, It end) {
 template <>
 std::string toHexString(const __uint128_t& v);
 
-namespace details {
-
 #define SCL_TO_HEX(v, c)                                                \
   do {                                                                  \
     if ((c) >= '0' && (c) <= '9')                                       \
@@ -97,7 +95,6 @@ T fromHexString(const std::string& s) {
 
 #undef SCL_TO_HEX
 
-}  // namespace details
-}  // namespace scl
+}  // namespace scl::details
 
 #endif  // SCL_HEX_H

include/scl/math/z2k.h

@@ -310,7 +310,7 @@ class Z2k final {
    */
   std::string toString() const {
     const auto w = m_value & MASK;
-    return toHexString(w);
+    return details::toHexString(w);
   }
 
   /**

include/scl/primitives/digest.h

@@ -42,7 +42,7 @@ using Digest = std::array<unsigned char, BITS / 8>;
  */
 template <typename DIGEST>
 std::string digestToString(const DIGEST& digest) {
-  return toHexString(digest.begin(), digest.end());
+  return details::toHexString(digest.begin(), digest.end());
 }
 
 }  // namespace scl

src/scl/hex.cc

@@ -20,7 +20,7 @@
 #include <cstdint>
 
 template <>
-std::string scl::toHexString(const __uint128_t& v) {
+std::string scl::details::toHexString(const __uint128_t& v) {
   std::string str;
   if (v == 0) {
     str = "0";