remove LCOV exclusions

Author: anderspkd

include/scl/math/array.h

@@ -83,7 +83,7 @@ class Array final {
       p.m_values[i] = T::read(src + i * T::byteSize());
     }
     return p;
-  }  // LCOV_EXCL_LINE
+  }
 
   /**
    * @brief Create an array filled with random elements.
@@ -96,7 +96,7 @@ class Array final {
       p.m_values[i] = T::random(prg);
     }
     return p;
-  }  // LCOV_EXCL_LINE
+  }
 
   /**
    * @brief Get an Array filled with the multiplicative identity
@@ -338,7 +338,7 @@ class Array final {
     Array<T, N> r = *this;
     r /= other;
     return r;
-  }  // LCOV_EXCL_LINE
+  }
 
   /**
    * @brief Get the value at a particular entry in the product element.

include/scl/math/ec.h

@@ -208,7 +208,7 @@ class EC final {
    */
   friend EC operator*(const ScalarField& scalar, const EC& point) {
     return point * scalar;
-  }  // LCOV_EXCL_LINE
+  }
 
   /**
    * @brief Negate this point.
@@ -252,7 +252,7 @@ class EC final {
    */
   bool isPointAtInfinity() const {
     return details::isPointAtInfinity<CURVE>(m_value);
-  }  // LCOV_EXCL_LINE
+  }
 
   /**
    * @brief Return this point as a pair of affine coordinates.
@@ -261,7 +261,7 @@ class EC final {
    */
   std::array<Field, 2> toAffine() const {
     return details::toAffine<CURVE>(m_value);
-  }  // LCOV_EXCL_LINE
+  }
 
   /**
    * @brief Normalize this point.
@@ -280,7 +280,7 @@ class EC final {
    */
   std::string toString() const {
     return details::toString<CURVE>(m_value);
-  }  // LCOV_EXCL_LINE
+  }
 
   /**
    * @brief Operator << for printing a curve point.
@@ -294,7 +294,7 @@ class EC final {
    */
   void write(unsigned char* dest, bool compress) const {
     details::toBytes<CURVE>(dest, m_value, compress);
-  }  // LCOV_EXCL_LINE
+  }
 
  private:
   typename CURVE::ValueType m_value;

include/scl/math/ff.h

@@ -62,7 +62,7 @@ class FF final {
     FF e;
     details::fromBytes<FIELD>(e.m_value, src);
     return e;
-  }  // LCOV_EXCL_LINE
+  }
 
   /**
    * @brief Create a random element, using a supplied PRG.
@@ -227,7 +227,7 @@ class FF final {
     details::negate<FIELD>(copy);
     r.m_value = copy;
     return r;
-  }  // LCOV_EXCL_LINE
+  }
 
   /**
    * @brief Negate a finite field element.

include/scl/math/matrix.h

@@ -145,7 +145,7 @@ class Matrix final {
       I(i, i) = ELEMENT(1);
     }
     return I;
-  }  // LCOV_EXCL_LINE
+  }
 
   /**
    * @brief Construct an empty 0-by-0 matrix.
@@ -454,7 +454,7 @@ Matrix<ELEMENT> Matrix<ELEMENT>::vandermonde(std::size_t n,
     }
   }
   return v;
-}  // LCOV_EXCL_LINE
+}
 
 template <typename ELEMENT>
 Matrix<ELEMENT> Matrix<ELEMENT>::hyperInvertible(std::size_t n, std::size_t m) {
@@ -489,7 +489,7 @@ Matrix<ELEMENT> Matrix<ELEMENT>::multiply(const Matrix<ELEMENT>& other) const {
     }
   }
   return result;
-}  // LCOV_EXCL_LINE
+}
 
 template <typename ELEMENT>
 Vector<ELEMENT> Matrix<ELEMENT>::multiply(const Vector<ELEMENT>& vector) const {
@@ -722,7 +722,7 @@ Vector<ELEMENT> extractSolution(const Matrix<ELEMENT>& A) {
     }
   }
   return x;
-}  // LCOV_EXCL_LINE
+}
 
 /**
  * @brief Check if a linear system has a solution.

include/scl/math/poly.h

@@ -61,7 +61,7 @@ class Polynomial {
       y = *it++ + y * x;
     }
     return y;
-  }  // LCOV_EXCL_LINE
+  }
 
   /**
    * @brief Access coefficients, with the constant term at position 0.
@@ -213,7 +213,7 @@ Vector<RING> padCoefficients(const Polynomial<RING>& p, std::size_t n) {
     }
   }
   return c;
-}  // LCOV_EXCL_LINE
+}
 
 template <typename RING>
 Polynomial<RING> Polynomial<RING>::add(const Polynomial<RING>& q) const {

include/scl/math/vector.h

@@ -46,7 +46,7 @@ T innerProd(IT0 xb, IT0 xe, IT1 yb) {
     v += *xb++ * *yb++;
   }
   return v;
-}  // LCOV_EXCL_LINE
+}
 
 /**
  * @brief Vector.
@@ -259,7 +259,7 @@ class Vector final {
       sum += v;
     }
     return sum;
-  }  // LCOV_EXCL_LINE
+  }
 
   /**
    * @brief Scale this vector by a constant.

include/scl/net/packet.h

@@ -128,7 +128,7 @@ class Packet {
     const auto sz = Serializer<T>::read(v, get() + m_read_ptr);
     m_read_ptr += sz;
     return v;
-  }  // LCOV_EXCL_LINE
+  }
 
   /**
    * @brief Write an object to this packet.
@@ -295,7 +295,7 @@ class Packet {
       // Not testing this at the moment. It would be better if allocation of the
       // internal buffer has handled by an allocator type of some sort. Possibly
       // one from the standard library.
-      throw std::bad_alloc();  // LCOV_EXCL_LINE
+      throw std::bad_alloc();
     }
     m_buffer.reset(static_cast<unsigned char*>(buf_new));
     m_cap = new_size;

include/scl/primitives/merkle.h

@@ -89,7 +89,7 @@ auto MerkleTree<HASH, LEAF>::hashLeafs(const std::vector<LEAF>& data)
   }
 
   return digests;
-}  // LCOV_EXCL_LINE
+}
 
 template <typename HASH, typename LEAF>
 auto MerkleTree<HASH, LEAF>::hash(const std::vector<LEAF>& data) -> DigestType {

include/scl/simulation/channel_id.h

@@ -23,6 +23,9 @@
 
 namespace scl {
 
+/**
+ * @brief x
+ */
 struct ChannelId final {
   std::size_t local;
   std::size_t remote;
@@ -36,6 +39,9 @@ struct ChannelId final {
 
 }  // namespace scl
 
+/**
+ * @brief x
+ */
 template <>
 struct std::hash<scl::ChannelId> {
   std::size_t operator()(const scl::ChannelId& channel_id) const {

src/scl/hex.cc

@@ -36,4 +36,4 @@ std::string scl::toHexString(const __uint128_t& v) {
     str = ss.str();
   }
   return str;
-}  // LCOV_EXCL_LINE
+}