[AdaptiveUiCodelab] review fixes

Author: jdkoren

AdaptiveUiCodelab/app/src/main/java/com/example/reply/data/local/LocalEmailsDataProvider.kt

@@ -27,7 +27,7 @@ import com.example.reply.data.MailboxType
 
 object LocalEmailsDataProvider {
 
-    private val threads = listOf(
+    private val replies = listOf(
         Email(
             4L,
             LocalAccountsDataProvider.getContactAccountByUid(11L),
@@ -116,7 +116,7 @@ object LocalEmailsDataProvider {
             """.trimIndent(),
             createAt = "20 mins ago",
             isStarred = true,
-            replies = threads,
+            replies = replies,
         ),
         Email(
             1L,
@@ -133,7 +133,7 @@ object LocalEmailsDataProvider {
                 Ali
             """.trimIndent(),
             createAt = "40 mins ago",
-            replies = threads,
+            replies = replies,
         ),
         Email(
             2L,
@@ -149,7 +149,7 @@ object LocalEmailsDataProvider {
             ),
             true,
             createAt = "1 hour ago",
-            replies = threads,
+            replies = replies,
         ),
         Email(
             3L,

AdaptiveUiCodelab/app/src/main/java/com/example/reply/ui/ReplyHomeViewModel.kt

@@ -24,6 +24,7 @@ import com.example.reply.data.EmailsRepositoryImpl
 import kotlinx.coroutines.flow.MutableStateFlow
 import kotlinx.coroutines.flow.StateFlow
 import kotlinx.coroutines.flow.catch
+import kotlinx.coroutines.flow.update
 import kotlinx.coroutines.launch
 
 class ReplyHomeViewModel(private val emailsRepository: EmailsRepository = EmailsRepositoryImpl()): ViewModel() {
@@ -54,10 +55,9 @@ class ReplyHomeViewModel(private val emailsRepository: EmailsRepository = Emails
     }
 
     fun setSelectedEmail(email: Email) {
-        val currentState = _uiState.value
-        _uiState.value = currentState.copy(
-            selectedEmail = email
-        )
+        _uiState.update {
+            it.copy(selectedEmail = email)
+        }
     }
 }
 

AdaptiveUiCodelab/app/src/main/java/com/example/reply/ui/ReplyListContent.kt

@@ -18,7 +18,6 @@ package com.example.reply.ui
 
 import androidx.compose.foundation.Image
 import androidx.compose.foundation.background
-import androidx.compose.foundation.clickable
 import androidx.compose.foundation.layout.Arrangement
 import androidx.compose.foundation.layout.Column
 import androidx.compose.foundation.layout.Row
@@ -93,11 +92,8 @@ fun ReplyEmailListItem(
     modifier: Modifier = Modifier
 ) {
     Card(
-        modifier = modifier
-            .padding(horizontal = 16.dp, vertical = 4.dp)
-            .clickable {
-                onEmailClick(email)
-            }
+        onClick = { onEmailClick(email) },
+        modifier = modifier.padding(horizontal = 16.dp, vertical = 4.dp)
     ) {
         Column(
             modifier = Modifier