From 9e94f74801ffe656a08897af625bdd58839aeb01 Mon Sep 17 00:00:00 2001 From: 852Kerfunkle <852Kerfunkle@users.noreply.github.com> Date: Fri, 3 Feb 2023 02:50:37 +0100 Subject: [PATCH] make the plugin work for SharedWorker --- src/index.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/index.js b/src/index.js index 4a6b99a..63123a6 100644 --- a/src/index.js +++ b/src/index.js @@ -40,13 +40,13 @@ export default class WorkerPlugin { for (const type of JS_TYPES) { factory.hooks.parser.for(`javascript/${type}`).tap(NAME, parser => { parser.hooks.new.for('imported var').tap(NAME, expr => { - if (expr.callee.name !== 'Worker') return false + if (expr.callee.name !== 'Worker' && expr.callee.name !== 'SharedWorker') return false const dep = parser.evaluateExpression(expr.arguments[0]); if (!dep.isString()) { parser.state.module.warnings.push({ - message: 'new Worker() will only be bundled if passed a String.' + message: 'new Worker() and new SharedWorker() will only be bundled if passed a String.' }); return false; } @@ -95,7 +95,7 @@ export default class WorkerPlugin { 'No instantiations of threads.js workers found.\n' + 'Please check that:\n' + ' 1. You have configured Babel / TypeScript to not transpile ES modules\n' + - ' 2. You import `Worker` from `threads` where you use it\n\n' + + ' 2. You import `Worker` or `SharedWorker` from `threads` where you use it\n\n' + 'For more details see: https://github.com/andywer/threads-plugin\n' }) }