Skip to content

Commit 1da8e2e

Browse files
author
Kuldeep Keshwar
committed
options_fix
1 parent 9fb75d6 commit 1da8e2e

File tree

7 files changed

+1223
-1116
lines changed

7 files changed

+1223
-1116
lines changed

.idea/workspace.xml

Lines changed: 69 additions & 505 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/scripts/directives/ng-accordion-group.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,9 @@ function noopPromise(){
1919
function AccordionGroup(){
2020

2121
}
22-
AccordionGroup.prototype.beforeOpen=noopPromise;
23-
AccordionGroup.prototype.beforeHide=noopPromise;
2422
AccordionGroup.prototype.down=function(animationFn){
2523
var _self=this;
26-
_self.beforeOpen().then(function(){
24+
_self.options.beforeOpen().then(function(){
2725
_self.body[animationFn]('slow');//slideDown
2826
_self.options.open=true;
2927
},function(error){
@@ -32,7 +30,7 @@ AccordionGroup.prototype.down=function(animationFn){
3230
};
3331
AccordionGroup.prototype.up=function(animationFn){
3432
var _self=this;
35-
_self.beforeHide().then(function(){
33+
_self.options.beforeHide().then(function(){
3634
_self.options.open=false;
3735
_self.body[animationFn]();//slideUp
3836
},function(error){
@@ -42,7 +40,9 @@ AccordionGroup.prototype.up=function(animationFn){
4240
function defaultAccordionGroupOptions(){
4341
return {
4442
open:false,
45-
disabled:false
43+
disabled:false,
44+
beforeOpen:noopPromise,
45+
beforeHide:noopPromise
4646
}
4747
}
4848
angular.module('uiAccordion')

dist/scripts/ui-accordion.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -114,11 +114,9 @@ function noopPromise(){
114114
function AccordionGroup(){
115115

116116
}
117-
AccordionGroup.prototype.beforeOpen=noopPromise;
118-
AccordionGroup.prototype.beforeHide=noopPromise;
119117
AccordionGroup.prototype.down=function(animationFn){
120118
var _self=this;
121-
_self.beforeOpen().then(function(){
119+
_self.options.beforeOpen().then(function(){
122120
_self.body[animationFn]('slow');//slideDown
123121
_self.options.open=true;
124122
},function(error){
@@ -127,7 +125,7 @@ AccordionGroup.prototype.down=function(animationFn){
127125
};
128126
AccordionGroup.prototype.up=function(animationFn){
129127
var _self=this;
130-
_self.beforeHide().then(function(){
128+
_self.options.beforeHide().then(function(){
131129
_self.options.open=false;
132130
_self.body[animationFn]();//slideUp
133131
},function(error){
@@ -137,7 +135,9 @@ AccordionGroup.prototype.up=function(animationFn){
137135
function defaultAccordionGroupOptions(){
138136
return {
139137
open:false,
140-
disabled:false
138+
disabled:false,
139+
beforeOpen:noopPromise,
140+
beforeHide:noopPromise
141141
}
142142
}
143143
angular.module('uiAccordion')

dist/scripts/ui-accordion.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)