ci: update prod scenario

Author: guidograzioli

molecule/prod_eap/converge.yml

@@ -2,49 +2,42 @@
 - name: Converge
   hosts: localhost
   gather_facts: no
-  vars:
-    client_id: "{{ lookup('env', 'PROD_JBOSSNETWORK_API_CLIENTID') }}"
-    client_secret: "{{ lookup('env', 'PROD_JBOSSNETWORK_API_SECRET') }}"
   tasks:
-    - name: Execute scenario if staging credentials are provided
-      when:
-        - client_id is defined and client_password is defined
-      block:
-        - name: "Ensures required secret are provided."
-          ansible.builtin.assert:
-            that:
-              - client_id is defined and client_id | length > 0
-              - client_secret is defined and client_secret | length > 0
-            fail_msg: "Missing required env vars PROD_JBOSSNETWORK_API_CLIENTID and/or PROD_JBOSSNETWORK_API_SECRET"
+    - name: "Ensures required secret are provided."
+      ansible.builtin.assert:
+        that:
+          - client_id is defined and client_id | length > 0
+          - client_secret is defined and client_secret | length > 0
+        fail_msg: "Missing required env vars PROD_JBOSSNETWORK_API_CLIENTID and/or PROD_JBOSSNETWORK_API_SECRET"
 
-        - name: Search EAP Product
-          middleware_automation.common.product_search:
-            client_id: "{{ client_id }}"
-            client_secret: "{{ client_secret }}"
-            product_type: DISTRIBUTION
-            product_version: '7.4'
-            product_category: appplatform
-          register: rhn_products
-          no_log: false
+    - name: Search EAP Product
+      middleware_automation.common.product_search:
+        client_id: "{{ lookup('env', 'PROD_JBOSSNETWORK_API_CLIENTID') }}"
+        client_secret: "{{ lookup('env', 'PROD_JBOSSNETWORK_API_SECRET') }}"
+        product_type: DISTRIBUTION
+        product_version: '7.4'
+        product_category: appplatform
+      register: rhn_products
+      no_log: false
 
-        - name: Search install zipfile
-          ansible.builtin.set_fact:
-            rhn_filtered_products: "{{ rhn_products.results | selectattr('file_path', 'match', '[^/]*/jboss-eap-7.4.0.zip$') }}"
+    - name: Search install zipfile
+      ansible.builtin.set_fact:
+        rhn_filtered_products: "{{ rhn_products.results | selectattr('file_path', 'match', '[^/]*/jboss-eap-7.4.0.zip$') }}"
 
-        - name: Retrieve product download using JBossNetwork API
-          middleware_automation.common.product_search:
-            client_id: "{{ client_id }}"
-            client_secret: "{{ client_secret }}"
-            product_type: BUGFIX
-            product_version: '7.4'
-            product_category: appplatform
-          register: rhn_products
-          no_log: true
+    - name: Retrieve product download using JBossNetwork API
+      middleware_automation.common.product_search:
+        client_id: "{{ client_id }}"
+        client_secret: "{{ client_secret }}"
+        product_type: BUGFIX
+        product_version: '7.4'
+        product_category: appplatform
+      register: rhn_products
+      no_log: true
 
-        - name: Determine patch versions list
-          ansible.builtin.set_fact:
-            filtered_versions: "{{ rhn_products.results | map(attribute='file_path') | select('match', '^[^/]*/jboss-eap-.*[0-9]*[.][0-9]*[.][0-9]*.*$') | map('regex_replace','[^/]*/jboss-eap-([0-9]*[.][0-9]*[.][0-9]*)-.*','\\1' ) | list | unique }}"
+    - name: Determine patch versions list
+      ansible.builtin.set_fact:
+        filtered_versions: "{{ rhn_products.results | map(attribute='file_path') | select('match', '^[^/]*/jboss-eap-.*[0-9]*[.][0-9]*[.][0-9]*.*$') | map('regex_replace','[^/]*/jboss-eap-([0-9]*[.][0-9]*[.][0-9]*)-.*','\\1' ) | list | unique }}"
 
-        - name: Determine latest version
-          ansible.builtin.debug:
-            msg: "JBoss EAP 7.4 most recent CP is version {{ filtered_versions | middleware_automation.common.version_sort | last }}"
+    - name: Determine latest version
+      ansible.builtin.debug:
+        msg: "JBoss EAP 7.4 most recent CP is version {{ filtered_versions | middleware_automation.common.version_sort | last }}"