From c3211e8cf093cc479f4d362dd80d65c87b8fa5f0 Mon Sep 17 00:00:00 2001 From: Iain McGinniss <309153+iainmcgin@users.noreply.github.com> Date: Mon, 29 Jun 2026 03:16:03 +0000 Subject: [PATCH] docs: correct stale gate_reflect_on_crate_feature doc comments The doc on buffa_build::Config::gate_reflect_on_crate_feature still said it was paired with generate_reflection_vtable "until the public ReflectMode selector lands" - that selector landed (reflect_mode() is public on the same type) and the linked method no longer exists, so the intra-doc link was broken. The codegen-side field doc repeated the same stale pairing claim. --- buffa-build/src/lib.rs | 7 ++++--- buffa-codegen/src/lib.rs | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/buffa-build/src/lib.rs b/buffa-build/src/lib.rs index f7aa5ce..8292bef 100644 --- a/buffa-build/src/lib.rs +++ b/buffa-build/src/lib.rs @@ -256,9 +256,10 @@ impl Config { /// `buffa-descriptor`-dependent (and `std`-requiring) reflection surface to /// be opt-in. `buffa-types` is the motivating case. /// - /// **Experimental and `#[doc(hidden)]`**, paired with - /// [`generate_reflection_vtable`](Self::generate_reflection_vtable) until the - /// public `ReflectMode` selector lands. + /// **Experimental and `#[doc(hidden)]`.** This knob only controls the + /// crate-feature gate on the emitted reflection impls; the reflection + /// codegen mode itself is selected via the public + /// [`reflect_mode`](Self::reflect_mode) selector. #[doc(hidden)] #[must_use] pub fn gate_reflect_on_crate_feature(mut self, enabled: bool) -> Self { diff --git a/buffa-codegen/src/lib.rs b/buffa-codegen/src/lib.rs index 2cc76e4..60ed075 100644 --- a/buffa-codegen/src/lib.rs +++ b/buffa-codegen/src/lib.rs @@ -1169,7 +1169,7 @@ pub struct CodeGenConfig { /// A low-level knob for crates whose generated code is a public interface /// (`buffa-types`, the conformance harness). Set directly by `gen_wkt_types` /// and exposed through `buffa_build::Config::gate_reflect_on_crate_feature` - /// (currently `#[doc(hidden)]`, paired with the experimental vtable flag). + /// (currently `#[doc(hidden)]`). /// /// Defaults to `false`. pub gate_reflect_on_crate_feature: bool,