Fix missing from docker images?

[jackrabbit128]

I recently encountered the problem reported and fixed in #12546.
Basically, in the docker-entrypoint.sh file, throw away a unix socket file if it wasn't cleaned up during container shutdown.
This fix is included in tags since version 3.14.0.

To my surprise, when downloading images from docker hub (tags 3.14.0 up to 3.17.0), the fix seems to be missing! Can anyone confirm that I'm not dreaming here?

This makes me wonder if anything else is missing... which would be bad...

Looking through the project code, it is not clear to me at all how or where the docker images are built and uploaded to docker hub. I hope the image builder just has an out-of-date copy of the docker-entrypoint.sh file.

[lMysticl]

You are not imagining it. The release images and the tagged APISIX source use different copies of the entrypoint script.

PR #12546 changed apache/apisix/docker/debian-dev/docker-entrypoint.sh. The Docker Hub release images are built from the separate apache/apisix-docker repository. Its Makefile copies utils/docker-entrypoint.sh into the Debian or Ubuntu build context, and that copy still removes worker_events.sock but not stream_worker_events.sock.

That means adding the fix to an APISIX source tag did not automatically add it to apache/apisix:* release images. This is packaging drift, not a stale local Docker cache. The same change needs to be ported to apache/apisix-docker/utils/docker-entrypoint.sh, followed by rebuilding the affected image tags. A small release-image test should also assert that both worker-event socket files are removed before OpenResty starts.

References: the original fix, the fixed 3.17.0 development entrypoint, the release-image entrypoint that is still missing the third cleanup, and the release build copying that separate script.

[jackrabbit128]

Thank you for confirming!

[juzhiyuan]

Tracked by #13752, and fixed by apache/apisix-docker#629

[lMysticl]

Thanks for following through with the fix. PR apache/apisix-docker#629 implements the same core fix I described above: porting the missing stream_worker_events.sock cleanup to the release-image entrypoint in apache/apisix-docker.

Since my earlier answer identified both the cause and the required fix before #13752 and #629 were opened, would you consider marking it as the accepted answer?

[jackrabbit128]

Thank you both for fixing it!