docs(arrow-select): document the InProgressArray copy methods#10057
Draft
alamb wants to merge 2 commits into
Draft
docs(arrow-select): document the InProgressArray copy methods#10057alamb wants to merge 2 commits into
alamb wants to merge 2 commits into
Conversation
Teach BatchCoalescer to reuse a FilterPredicate when coalescing filtered batches whose non-primitive columns are inline Utf8View/BinaryView values. This avoids materializing an intermediate filtered RecordBatch for sparse filters and copies inline views and nulls directly into the in-progress arrays. Keep materialized filtering for dense filters, batches that do not fit the coalescer buffer, and byte-view arrays with external buffers. Use a looser dense threshold for multi-column batches, where sharing the row selection across columns pays for itself. Add shared FilterSelection iterators so primitive and byte-view coalescers can consume materialized or lazy row selections without matching per row. Signed-off-by: cl <cailue@apache.org>
Add rationale and clarify the relationships between the `InProgressArray` trait's copy methods (`copy_rows`, `copy_rows_by_filter`, `copy_rows_by_filter_from`, `copy_rows_by_selection`), including which read the source set via `set_source` versus taking it directly. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation follow-up for #9755.
Note
Stacked on top of #9755 (not yet merged), so the diff also shows that PR's feature commit. The contribution here is the single docs commit.
Comments only — no code changes. Documents the
InProgressArraycopy methods and clarifies which operate on the source set viaset_sourceversus the one that takes the source directly.