arrow-buffer: implement Saturating, Checked num-traits for i256#10088
Open
theirix wants to merge 2 commits into
Open
arrow-buffer: implement Saturating, Checked num-traits for i256#10088theirix wants to merge 2 commits into
theirix wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Following up on #9417, there are a few missing numeric traits for i256 from num-traits:
Most likely, it brings us to the most conformant state, since https://docs.rs/num-traits/latest/num_traits/int/trait.PrimInt.html cannot be implemented because of
NumCasttrait - it is not compatible with arrow-buffer'sstd::convert::Fromtrait implementations (they returnSelf, notOption<Self>)What changes are included in this PR?
Traits:
Are these changes tested?
Existing and new unit tests
Are there any user-facing changes?