ninja-fix – Fix eclipse-warnings error for CASSANDRA-19564

jaydeep1984 · michaelsembwever · commit bfcba9c7c40a · 2025-10-27T09:46:21.000+01:00
``` eclipse-warnings: [mkdir] Created dir: /home/jenkins/jenkins-slave/workspace/Cassandra-4.1-artifacts/jdk/jdk_1.8_latest/label/cassandra/build/ecj [echo] Running Eclipse Code Analysis. Output logged to /home/jenkins/jenkins-slave/workspace/Cassandra-4.1-artifacts/jdk/jdk_1.8_latest/label/cassandra/build/ecj/eclipse_compiler_checks.txt [java] ---------- [java] 1. ERROR in /home/jenkins/jenkins-slave/workspace/Cassandra-4.1-artifacts/jdk/jdk_1.8_latest/label/cassandra/src/java/org/apache/cassandra/index/SecondaryIndexManager.java (at line 931) [java] partition = ImmutableBTreePartition.create(onePartition).unfilteredIterator(); [java] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [java] Resource 'partition' should be managed by try-with-resource [java] ---------- [java] 1 problem (1 error) ```
diff --git a/src/java/org/apache/cassandra/index/SecondaryIndexManager.java b/src/java/org/apache/cassandra/index/SecondaryIndexManager.java
@@ -919,6 +919,7 @@ public void indexPartition(DecoratedKey key, Set<Index> indexes, int pageSize, R
             SinglePartitionPager pager = new SinglePartitionPager(cmd, null, ProtocolVersion.CURRENT);
             while (!pager.isExhausted())
             {
+                @SuppressWarnings("resource")
                 UnfilteredRowIterator partition;
                 try (ReadExecutionController controller = cmd.executionController();
                      UnfilteredPartitionIterator page = pager.fetchPageUnfiltered(baseCfs.metadata(), pageSize, controller))

Original file line number	Diff line number	Diff line change
`@@ -919,6 +919,7 @@ public void indexPartition(DecoratedKey key, Set<Index> indexes, int pageSize, R`
`919`	`919`	`SinglePartitionPager pager = new SinglePartitionPager(cmd, null, ProtocolVersion.CURRENT);`
`920`	`920`	`while (!pager.isExhausted())`
`921`	`921`	`{`
	`922`	`+ @SuppressWarnings("resource")`
`922`	`923`	`UnfilteredRowIterator partition;`
`923`	`924`	`try (ReadExecutionController controller = cmd.executionController();`
`924`	`925`	`UnfilteredPartitionIterator page = pager.fetchPageUnfiltered(baseCfs.metadata(), pageSize, controller))`