chore: enforce clippy::allow_attributes for physical crates (#19185)

## Which issue does this PR close?

<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases.
You can link an issue to this PR using the GitHub syntax. For example
`Closes #123` indicates that this PR will close issue #123.
-->

- Part of #18881.

## Rationale for this change

<!--
Why are you proposing this change? If this is already explained clearly
in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand
your changes and offer better suggestions for fixes.
-->

Please refer to #18881.

## What changes are included in this PR?

<!--
There is no need to duplicate the description in the issue here but it
is sometimes worth providing a summary of the individual changes in this
PR.
-->

+ Added `#![deny(clippy::allow_attributes)]` to the following crates:
  + `datafusion-physical-expr-adapter`.
  + `datafusion-physical-expr-common`.
  + `datafusion-physical-optimizer`.
+ Removed `#[allow(deprecated)]` from
https://github.com/apache/datafusion/blob/cb2f3d2a86f15aa857b8a297277d9c79a36bd6e8/datafusion/physical-optimizer/src/filter_pushdown.rs#L432-L443
as [lint is only fulfilled on usage of `#[deprecated]`
items](https://doc.rust-lang.org/reference/attributes/diagnostics.html#r-attributes.diagnostics.deprecated.intro),
thus when `#[expect(deprecated)]` is used instead of
`#[allow(deprecated)]` it results in `error: this lint expectation is
unfulfilled`.
+ Kept `#[allow(clippy::only_used_in_recursion)]` in
https://github.com/apache/datafusion/blob/6746007826ebd3fcb5614bf87183674435bbb134/datafusion/physical-optimizer/src/aggregate_statistics.rs#L43-L98
as `#[expect(clippy::only_used_in_recursion)]` resulted in `error: this
lint expectation is unfulfilled` when running `sh
ci/scripts/rust_clippy.sh` but was successful when running `cargo clippy
-p datafusion-physical-optimizer -- -D warning`. Ref:
#18881 (comment).

For now, easiest solution is to locally expect
`#[expect(clippy::allow_attributes)]`.

## Are these changes tested?

<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code

If tests are not included in your PR, please explain why (for example,
are they covered by existing tests)?
-->

Successfully ran `sh ci/scripts/rust_clippy.sh`.

## Are there any user-facing changes?

<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->

<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->

No.

Author: carlosahs

datafusion/physical-expr-adapter/src/lib.rs

@@ -21,6 +21,8 @@
     html_favicon_url = "https://raw.githubusercontent.com/apache/datafusion/19fe44cf2f30cbdd63d4a4f52c74055163c6cc38/docs/logos/standalone_logo/logo_original.svg"
 )]
 #![cfg_attr(docsrs, feature(doc_cfg))]
+// https://github.com/apache/datafusion/issues/18881
+#![deny(clippy::allow_attributes)]
 
 //! Physical expression schema adaptation utilities for DataFusion
 

datafusion/physical-expr-common/src/lib.rs

@@ -24,6 +24,8 @@
 // https://github.com/apache/datafusion/issues/11143
 #![deny(clippy::clone_on_ref_ptr)]
 #![cfg_attr(test, allow(clippy::needless_pass_by_value))]
+// https://github.com/apache/datafusion/issues/18881
+#![deny(clippy::allow_attributes)]
 
 //! Physical Expr Common packages for [DataFusion]
 //! This package contains high level PhysicalExpr trait

datafusion/physical-optimizer/src/aggregate_statistics.rs

@@ -33,14 +33,15 @@ use crate::{OptimizerContext, PhysicalOptimizerRule};
 pub struct AggregateStatistics {}
 
 impl AggregateStatistics {
-    #[allow(missing_docs)]
+    #[expect(missing_docs)]
     pub fn new() -> Self {
         Self {}
     }
 }
 
 impl PhysicalOptimizerRule for AggregateStatistics {
     #[cfg_attr(feature = "recursive_protection", recursive::recursive)]
+    #[expect(clippy::allow_attributes)] // See https://github.com/apache/datafusion/issues/18881#issuecomment-3621545670
     #[allow(clippy::only_used_in_recursion)] // See https://github.com/rust-lang/rust-clippy/issues/14566
     fn optimize_plan(
         &self,

datafusion/physical-optimizer/src/coalesce_batches.rs

@@ -38,7 +38,7 @@ use datafusion_common::tree_node::{Transformed, TransformedResult, TreeNode};
 pub struct CoalesceBatches {}
 
 impl CoalesceBatches {
-    #[allow(missing_docs)]
+    #[expect(missing_docs)]
     pub fn new() -> Self {
         Self::default()
     }

datafusion/physical-optimizer/src/combine_partial_final_agg.rs

@@ -39,7 +39,7 @@ use datafusion_physical_expr::{physical_exprs_equal, PhysicalExpr};
 pub struct CombinePartialFinalAggregate {}
 
 impl CombinePartialFinalAggregate {
-    #[allow(missing_docs)]
+    #[expect(missing_docs)]
     pub fn new() -> Self {
         Self {}
     }

datafusion/physical-optimizer/src/enforce_distribution.rs

@@ -184,7 +184,7 @@ use itertools::izip;
 pub struct EnforceDistribution {}
 
 impl EnforceDistribution {
-    #[allow(missing_docs)]
+    #[expect(missing_docs)]
     pub fn new() -> Self {
         Self {}
     }

datafusion/physical-optimizer/src/enforce_sorting/mod.rs

@@ -79,7 +79,7 @@ use itertools::izip;
 pub struct EnforceSorting {}
 
 impl EnforceSorting {
-    #[allow(missing_docs)]
+    #[expect(missing_docs)]
     pub fn new() -> Self {
         Self {}
     }

datafusion/physical-optimizer/src/filter_pushdown.rs

@@ -429,7 +429,6 @@ impl PhysicalOptimizerRule for FilterPushdown {
         )
     }
 
-    #[allow(deprecated)]
     fn optimize(
         &self,
         plan: Arc<dyn ExecutionPlan>,

datafusion/physical-optimizer/src/join_selection.rs

@@ -47,7 +47,7 @@ use std::sync::Arc;
 pub struct JoinSelection {}
 
 impl JoinSelection {
-    #[allow(missing_docs)]
+    #[expect(missing_docs)]
     pub fn new() -> Self {
         Self {}
     }

datafusion/physical-optimizer/src/lib.rs

@@ -24,6 +24,8 @@
 // https://github.com/apache/datafusion/issues/11143
 #![deny(clippy::clone_on_ref_ptr)]
 #![cfg_attr(test, allow(clippy::needless_pass_by_value))]
+// https://github.com/apache/datafusion/issues/18881
+#![deny(clippy::allow_attributes)]
 
 pub mod aggregate_statistics;
 pub mod coalesce_batches;