Merge pull request #462 from apache/fix_tdigest

AlexanderSaydakov · web-flow · commit a7d4055bfde5 · 2025-07-14T22:54:15.000-07:00
porting bug fix from Java
diff --git a/tdigest/include/tdigest_impl.hpp b/tdigest/include/tdigest_impl.hpp
@@ -193,7 +193,7 @@ T tdigest<T, A>::get_quantile(double rank) const {
   }
   const double w1 = weight - centroids_weight_ - centroids_.back().get_weight() / 2.0;
   const double w2 = centroids_.back().get_weight() / 2.0 - w1;
-  return weighted_average(centroids_.back().get_weight(), w1, max_, w2);
+  return weighted_average(centroids_.back().get_mean(), w1, max_, w2);
 }
 
 template<typename T, typename A>

Original file line number	Diff line number	Diff line change
`@@ -193,7 +193,7 @@ T tdigest<T, A>::get_quantile(double rank) const {`
`193`	`193`	`}`
`194`	`194`	`const double w1 = weight - centroids_weight_ - centroids_.back().get_weight() / 2.0;`
`195`	`195`	`const double w2 = centroids_.back().get_weight() / 2.0 - w1;`
`196`		`- return weighted_average(centroids_.back().get_weight(), w1, max_, w2);`
	`196`	`+ return weighted_average(centroids_.back().get_mean(), w1, max_, w2);`
`197`	`197`	`}`
`198`	`198`
`199`	`199`	`template<typename T, typename A>`