HBASE-29779: Call super coprocessor instead of returning for system tables

Author: sharmaar12

hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/ReadOnlyController.java

@@ -105,6 +105,10 @@ private void internalReadOnlyGuard() throws IOException {
     }
   }
 
+  private boolean isOperationOnUserTable(final ObserverContext<? extends RegionCoprocessorEnvironment> c){
+    return !c.getEnvironment().getRegionInfo().getTable().isSystemTable();
+  }
+
   @Override
   public void start(CoprocessorEnvironment env) throws IOException {
     if (env instanceof MasterCoprocessorEnvironment) {
@@ -132,7 +136,9 @@ public Optional<RegionObserver> getRegionObserver() {
   @Override
   public void preFlush(final ObserverContext<? extends RegionCoprocessorEnvironment> c,
     FlushLifeCycleTracker tracker) throws IOException {
-    internalReadOnlyGuard();
+    if(isOperationOnUserTable(c)){
+      internalReadOnlyGuard();
+    }
     RegionObserver.super.preFlush(c, tracker);
   }
 
@@ -200,53 +206,45 @@ public InternalScanner preCompact(ObserverContext<? extends RegionCoprocessorEnv
   @Override
   public void prePut(ObserverContext<? extends RegionCoprocessorEnvironment> c, Put put,
     WALEdit edit, Durability durability) throws IOException {
-    TableName tableName = c.getEnvironment().getRegionInfo().getTable();
-    if (tableName.isSystemTable()) {
-      return;
+    if(isOperationOnUserTable(c)){
+      internalReadOnlyGuard();
     }
-    internalReadOnlyGuard();
     RegionObserver.super.prePut(c, put, edit, durability);
   }
 
   @Override
   public void prePut(ObserverContext<? extends RegionCoprocessorEnvironment> c, Put put,
     WALEdit edit) throws IOException {
-    TableName tableName = c.getEnvironment().getRegionInfo().getTable();
-    if (tableName.isSystemTable()) {
-      return;
+    if(isOperationOnUserTable(c)){
+      internalReadOnlyGuard();
     }
-    internalReadOnlyGuard();
     RegionObserver.super.prePut(c, put, edit);
   }
 
   @Override
   public void preDelete(ObserverContext<? extends RegionCoprocessorEnvironment> c, Delete delete,
     WALEdit edit, Durability durability) throws IOException {
-    if (c.getEnvironment().getRegionInfo().getTable().isSystemTable()) {
-      return;
+    if(isOperationOnUserTable(c)){
+      internalReadOnlyGuard();
     }
-    internalReadOnlyGuard();
     RegionObserver.super.preDelete(c, delete, edit, durability);
   }
 
   @Override
   public void preDelete(ObserverContext<? extends RegionCoprocessorEnvironment> c, Delete delete,
     WALEdit edit) throws IOException {
-    if (c.getEnvironment().getRegionInfo().getTable().isSystemTable()) {
-      return;
+    if(isOperationOnUserTable(c)){
+      internalReadOnlyGuard();
     }
-    internalReadOnlyGuard();
     RegionObserver.super.preDelete(c, delete, edit);
   }
 
   @Override
   public void preBatchMutate(ObserverContext<? extends RegionCoprocessorEnvironment> c,
     MiniBatchOperationInProgress<Mutation> miniBatchOp) throws IOException {
-    TableName tableName = c.getEnvironment().getRegionInfo().getTable();
-    if (tableName.isSystemTable()) {
-      return;
+    if(isOperationOnUserTable(c)){
+      internalReadOnlyGuard();
     }
-    internalReadOnlyGuard();
     RegionObserver.super.preBatchMutate(c, miniBatchOp);
   }
 
@@ -288,7 +286,7 @@ public boolean preCheckAndPutAfterRowLock(
   public boolean preCheckAndDelete(ObserverContext<? extends RegionCoprocessorEnvironment> c,
     byte[] row, byte[] family, byte[] qualifier, CompareOperator op, ByteArrayComparable comparator,
     Delete delete, boolean result) throws IOException {
-    if (!c.getEnvironment().getRegionInfo().getTable().isSystemTable()) {
+    if(isOperationOnUserTable(c)){
       internalReadOnlyGuard();
     }
     return RegionObserver.super.preCheckAndDelete(c, row, family, qualifier, op, comparator, delete,
@@ -298,7 +296,7 @@ public boolean preCheckAndDelete(ObserverContext<? extends RegionCoprocessorEnvi
   @Override
   public boolean preCheckAndDelete(ObserverContext<? extends RegionCoprocessorEnvironment> c,
     byte[] row, Filter filter, Delete delete, boolean result) throws IOException {
-    if (!c.getEnvironment().getRegionInfo().getTable().isSystemTable()) {
+    if(isOperationOnUserTable(c)){
       internalReadOnlyGuard();
     }
     return RegionObserver.super.preCheckAndDelete(c, row, filter, delete, result);
@@ -309,7 +307,7 @@ public boolean preCheckAndDeleteAfterRowLock(
     ObserverContext<? extends RegionCoprocessorEnvironment> c, byte[] row, byte[] family,
     byte[] qualifier, CompareOperator op, ByteArrayComparable comparator, Delete delete,
     boolean result) throws IOException {
-    if (!c.getEnvironment().getRegionInfo().getTable().isSystemTable()) {
+    if(isOperationOnUserTable(c)){
       internalReadOnlyGuard();
     }
     return RegionObserver.super.preCheckAndDeleteAfterRowLock(c, row, family, qualifier, op,
@@ -320,7 +318,7 @@ public boolean preCheckAndDeleteAfterRowLock(
   public boolean preCheckAndDeleteAfterRowLock(
     ObserverContext<? extends RegionCoprocessorEnvironment> c, byte[] row, Filter filter,
     Delete delete, boolean result) throws IOException {
-    if (!c.getEnvironment().getRegionInfo().getTable().isSystemTable()) {
+    if(isOperationOnUserTable(c)){
       internalReadOnlyGuard();
     }
     return RegionObserver.super.preCheckAndDeleteAfterRowLock(c, row, filter, delete, result);