Skip to content

Commit e7f66f3

Browse files
committed
Docs: Remove stale reference to closed #2152 in streaming write docstrings
1 parent 9d36e23 commit e7f66f3

3 files changed

Lines changed: 5 additions & 9 deletions

File tree

pyiceberg/io/pyarrow.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2881,8 +2881,7 @@ def _dataframe_to_data_files(
28812881
For a ``pa.RecordBatchReader`` batches are streamed and microbatched into
28822882
target-sized files using bounded memory (see :func:`bin_pack_record_batches`).
28832883
Streaming writes are currently only supported on unpartitioned tables;
2884-
partitioned support is tracked in
2885-
https://github.com/apache/iceberg-python/issues/2152.
2884+
partitioned streaming support is not yet implemented.
28862885
28872886
Returns:
28882887
An iterable that supplies datafiles that represent the input data.
@@ -2909,8 +2908,7 @@ def _dataframe_to_data_files(
29092908
if not table_metadata.spec().is_unpartitioned():
29102909
raise NotImplementedError(
29112910
"Writing a pa.RecordBatchReader to a partitioned table is not yet supported. "
2912-
"Materialise the reader as a pa.Table first, or follow "
2913-
"https://github.com/apache/iceberg-python/issues/2152 for partitioned streaming support."
2911+
"Materialise the reader as a pa.Table first."
29142912
)
29152913
yield from write_file(
29162914
io=io,

pyiceberg/table/__init__.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -473,8 +473,7 @@ def append(
473473
474474
Streaming writes are currently only supported on unpartitioned tables;
475475
passing a ``pa.RecordBatchReader`` for a partitioned table raises
476-
``NotImplementedError``. See
477-
https://github.com/apache/iceberg-python/issues/2152.
476+
``NotImplementedError``.
478477
479478
Note:
480479
When ``df`` is a ``pa.RecordBatchReader`` the reader is consumed
@@ -621,8 +620,7 @@ def overwrite(
621620
622621
Streaming writes are currently only supported on unpartitioned tables;
623622
passing a ``pa.RecordBatchReader`` for a partitioned table raises
624-
``NotImplementedError``. See
625-
https://github.com/apache/iceberg-python/issues/2152.
623+
``NotImplementedError``.
626624
627625
Note:
628626
When ``df`` is a ``pa.RecordBatchReader`` the reader is consumed

tests/catalog/test_catalog_behaviors.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1216,7 +1216,7 @@ def test_drop_namespace_raises_error_when_namespace_not_empty(
12161216
# RecordBatchReader streaming append/overwrite tests
12171217
#
12181218
# Streaming writes accept a pa.RecordBatchReader and microbatch it into target-sized
1219-
# Parquet files instead of materialising the full Arrow Table in memory. Tracks
1219+
# Parquet files instead of materialising the full Arrow Table in memory. Introduced in
12201220
# https://github.com/apache/iceberg-python/issues/2152.
12211221

12221222

0 commit comments

Comments
 (0)