Skip to content

Bump Griffe to 1.4.0 #2527

@Fokko

Description

@Fokko

Feature Request / Improvement

Dependabot was so kind to create a PR to bump Griffe: #2439

However, there are some issues with the docs that prohibit us from updating:

  make docs-build
  shell: /usr/bin/bash -e {0}
  env:
    pythonLocation: /opt/hostedtoolcache/Python/3.12.11/x64
    PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.12.11/x64/lib/pkgconfig
    Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.11/x64
    Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.11/x64
    Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.11/x64
    LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.12.11/x64/lib
poetry run mkdocs build -f mkdocs/mkdocs.yml --strict
INFO    -  Cleaning site directory
INFO    -  Building documentation to directory: /home/runner/work/iceberg-python/iceberg-python/mkdocs/site
INFO    -  Doc file 'SUMMARY.md' contains an unrecognized relative link 'reference/', it was left as is.
INFO    -  Doc file 'configuration.md' contains an unrecognized relative link '../reference/pyiceberg/table/locations/#pyiceberg.table.locations.LocationProvider', it was left as is. Did you mean 'reference/pyiceberg/table/locations.md#pyiceberg.table.locations.LocationProvider'?
WARNING -  griffe: pyiceberg/catalog/__init__.py:485: No type or annotation for parameter 'identifier Union[str, Identifier]'
WARNING -  griffe: pyiceberg/catalog/__init__.py:485: Parameter 'identifier Union[str, Identifier]' does not appear in the function signature
WARNING -  griffe: pyiceberg/catalog/__init__.py:486: No type or annotation for parameter 'metadata_location str'
WARNING -  griffe: pyiceberg/catalog/__init__.py:486: Parameter 'metadata_location str' does not appear in the function signature
WARNING -  griffe: pyiceberg/catalog/__init__.py:692: No type or annotation for parameter 'identifier (str | Identifier'
WARNING -  griffe: pyiceberg/catalog/__init__.py:692: Parameter 'identifier (str | Identifier' does not appear in the function signature
WARNING -  griffe: pyiceberg/catalog/bigquery_metastore.py:275: No type or annotation for parameter 'identifier Union[str, Identifier]'
WARNING -  griffe: pyiceberg/catalog/bigquery_metastore.py:275: Parameter 'identifier Union[str, Identifier]' does not appear in the function signature
WARNING -  griffe: pyiceberg/catalog/bigquery_metastore.py:276: No type or annotation for parameter 'metadata_location str'
WARNING -  griffe: pyiceberg/catalog/bigquery_metastore.py:276: Parameter 'metadata_location str' does not appear in the function signature
WARNING -  griffe: pyiceberg/catalog/dynamodb.py:219: No type or annotation for parameter 'identifier Union[str, Identifier]'
WARNING -  griffe: pyiceberg/catalog/dynamodb.py:219: Parameter 'identifier Union[str, Identifier]' does not appear in the function signature
WARNING -  griffe: pyiceberg/catalog/dynamodb.py:220: No type or annotation for parameter 'metadata_location str'
WARNING -  griffe: pyiceberg/catalog/dynamodb.py:220: Parameter 'metadata_location str' does not appear in the function signature
WARNING -  griffe: pyiceberg/catalog/glue.py:476: No type or annotation for parameter 'identifier Union[str, Identifier]'
WARNING -  griffe: pyiceberg/catalog/glue.py:476: Parameter 'identifier Union[str, Identifier]' does not appear in the function signature
WARNING -  griffe: pyiceberg/catalog/glue.py:477: No type or annotation for parameter 'metadata_location str'
WARNING -  griffe: pyiceberg/catalog/glue.py:477: Parameter 'metadata_location str' does not appear in the function signature
WARNING -  griffe: pyiceberg/catalog/hive.py:446: No type or annotation for parameter 'identifier Union[str, Identifier]'
WARNING -  griffe: pyiceberg/catalog/hive.py:446: Parameter 'identifier Union[str, Identifier]' does not appear in the function signature
WARNING -  griffe: pyiceberg/catalog/hive.py:447: No type or annotation for parameter 'metadata_location str'
WARNING -  griffe: pyiceberg/catalog/hive.py:447: Parameter 'metadata_location str' does not appear in the function signature
WARNING -  griffe: pyiceberg/catalog/noop.py:78: No type or annotation for parameter 'identifier Union[str, Identifier]'
WARNING -  griffe: pyiceberg/catalog/noop.py:78: Parameter 'identifier Union[str, Identifier]' does not appear in the function signature
WARNING -  griffe: pyiceberg/catalog/noop.py:79: No type or annotation for parameter 'metadata_location str'
WARNING -  griffe: pyiceberg/catalog/noop.py:79: Parameter 'metadata_location str' does not appear in the function signature
WARNING -  griffe: pyiceberg/catalog/sql.py:244: No type or annotation for parameter 'identifier Union[str, Identifier]'
WARNING -  griffe: pyiceberg/catalog/sql.py:244: Parameter 'identifier Union[str, Identifier]' does not appear in the function signature
WARNING -  griffe: pyiceberg/catalog/sql.py:245: No type or annotation for parameter 'metadata_location str'
WARNING -  griffe: pyiceberg/catalog/sql.py:245: Parameter 'metadata_location str' does not appear in the function signature
WARNING -  griffe: pyiceberg/catalog/rest/__init__.py:578: No type or annotation for parameter 'identifier Union[str, Identifier]'
WARNING -  griffe: pyiceberg/catalog/rest/__init__.py:578: Parameter 'identifier Union[str, Identifier]' does not appear in the function signature
WARNING -  griffe: pyiceberg/catalog/rest/__init__.py:579: No type or annotation for parameter 'metadata_location str'
WARNING -  griffe: pyiceberg/catalog/rest/__init__.py:579: Parameter 'metadata_location str' does not appear in the function signature
INFO    -  Doc file 'configuration.md' contains a link 'api.md#write-support', but the doc 'api.md' does not contain an anchor '#write-support'.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions