infra: change CI to only require approval for first-time contributors

[kevinjqliu]

Apache Iceberg version

None

Please describe the bug 🐞

Currently all PRs require approval before running CI. @geruh mentioned that in apache/iceberg repo, this is not the case.

Looking into github's documentation, there's a setting to change this behavior

• Require approval for first-time contributors who are new to GitHub. Only users who are both new on GitHub and who have never had a commit or pull request merged into this repository will require approval to run workflows.
• Require approval for first-time contributors. Only users who have never had a commit or pull request merged into this repository will require approval to run workflows.
• Require approval for all external contributors All users that are not a member or owner of this repository and not a member of the organization will require approval to run workflows.

Seems like apache/iceberg-python is currently set to "Require approval for all external contributors", I think it might be a good idea to change it to "Require approval for first-time contributors"

Happy to bring this up in the devlist :)

PS I dont see this setting in my view of https://github.com/apache/iceberg-python/settings, maybe we need to get apache infra to change it

Willingness to contribute

• I can contribute a fix for this bug independently
• I would be willing to contribute a fix for this bug with guidance from the Iceberg community
• I cannot contribute a fix for this bug at this time

[Fokko]

Thanks for bringing this up @kevinjqliu, I also noticed this. Please check for earlier discussions on the dev-list, because I'm pretty sure that there was consensus to only require a check the first time.

[kevinjqliu]

Thanks for the pointer. I found the past devlist discussion: "[Discuss] Change iceberg-python and iceberg-go CI Settings to only require approval for first time contributors"

Honah raised an issue with apache infra, https://issues.apache.org/jira/browse/INFRA-25457 and it was marked as resolved.

@Fokko are you able to double check this setting? Should be in https://github.com/apache/iceberg-python/settings

[Aniketsy]

I’d love to work on this if it hasn’t been resolved yet.

[kevinjqliu]

Thanks for the offer @Aniketsy, the next step is to reach out to apache infra to modify the settings.
I created https://issues.apache.org/jira/browse/INFRA-27351

[kevinjqliu]

Apache infra confirmed that change was made to these repos:

• https://github.com/apache/iceberg
• https://github.com/apache/iceberg-python
• https://github.com/apache/iceberg-rust
• https://github.com/apache/iceberg-go
• https://github.com/apache/iceberg-cpp

iceberg-rust and iceberg-cpp already had this setting

I see this is already working for apache/iceberg#14414
lets see another PR from iceberg-python or iceberg-go to confirm

[kevinjqliu]

i see it works for #2660
great!

[kevinjqliu]

sent out a devlist thread https://lists.apache.org/thread/6x6os4q37vvzmpcq8ry5dcvvd1knjwwn