Skip to content

Commit 2a87e76

Browse files
committed
Address review feedback: remove static import and rename parameter
- Remove static import for rebuilt() method, use qualified CacheResult.rebuilt() instead - Rename parameter 'orig' to 'original' for clarity in both rebuilt() and rebuilded() methods
1 parent 0fc5d22 commit 2a87e76

File tree

2 files changed

+12
-5
lines changed

2 files changed

+12
-5
lines changed

src/main/java/org/apache/maven/buildcache/CacheControllerImpl.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,6 @@
102102
import static org.apache.maven.buildcache.CacheResult.empty;
103103
import static org.apache.maven.buildcache.CacheResult.failure;
104104
import static org.apache.maven.buildcache.CacheResult.partialSuccess;
105-
import static org.apache.maven.buildcache.CacheResult.rebuilt;
106105
import static org.apache.maven.buildcache.CacheResult.success;
107106
import static org.apache.maven.buildcache.RemoteCacheRepository.BUILDINFO_XML;
108107
import static org.apache.maven.buildcache.checksum.KeyUtils.getVersionlessProjectKey;
@@ -529,7 +528,7 @@ public void save(
529528
hashFactory.getAlgorithm());
530529
populateGitInfo(build, session);
531530
build.getDto().set_final(cacheConfig.isSaveToRemoteFinal());
532-
cacheResults.put(getVersionlessProjectKey(project), rebuilt(cacheResult, build));
531+
cacheResults.put(getVersionlessProjectKey(project), CacheResult.rebuilt(cacheResult, build));
533532

534533
localCache.beforeSave(context);
535534

src/main/java/org/apache/maven/buildcache/CacheResult.java

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,10 +70,18 @@ public static CacheResult failure(CacheContext context) {
7070
return new CacheResult(RestoreStatus.FAILURE, null, context);
7171
}
7272

73-
public static CacheResult rebuilt(CacheResult orig, Build build) {
74-
requireNonNull(orig);
73+
public static CacheResult rebuilt(CacheResult original, Build build) {
74+
requireNonNull(original);
7575
requireNonNull(build);
76-
return new CacheResult(orig.status, build, orig.context);
76+
return new CacheResult(original.status, build, original.context);
77+
}
78+
79+
/**
80+
* @deprecated Use {@link #rebuilt(CacheResult, Build)} instead.
81+
*/
82+
@Deprecated
83+
public static CacheResult rebuilded(CacheResult original, Build build) {
84+
return rebuilt(original, build);
7785
}
7886

7987
public boolean isSuccess() {

0 commit comments

Comments
 (0)