Skip to content

Commit 24d405a

Browse files
committed
fix: windows and android-x86 quickjs-ng build failures
Add ilammy/msvc-dev-cmd to put cl.exe on PATH for Windows shim build. Pass -msse2 -mfpmath=sse for Android x86 to skip buggy x87 FPU asm.
1 parent 9679417 commit 24d405a

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

.github/workflows/build.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@ jobs:
2323
cmake -S quickjs -B build -G "Visual Studio 17 2022" -A x64 -DBUILD_SHARED_LIBS=ON
2424
cmake --build build --config Release
2525
26+
- uses: ilammy/msvc-dev-cmd@v1
27+
2628
- name: Build shim
2729
run: |
2830
cl /LD /O2 /Febuild/Release/qjs_shim.dll shim~/qjs_shim.c /Iquickjs /link /LIBPATH:build/Release qjs.lib
@@ -265,7 +267,8 @@ jobs:
265267
-DANDROID_ABI=x86 \
266268
-DANDROID_PLATFORM=android-21 \
267269
-DBUILD_SHARED_LIBS=ON \
268-
-DCMAKE_BUILD_TYPE=Release
270+
-DCMAKE_BUILD_TYPE=Release \
271+
-DCMAKE_C_FLAGS="-msse2 -mfpmath=sse"
269272
cmake --build build -j$(nproc)
270273
271274
- name: Build shim

0 commit comments

Comments
 (0)