chore: Migrate to ty type checker (#562)

Author: vdusek

.gitignore

@@ -3,6 +3,7 @@ __pycache__
 .mypy_cache
 .pytest_cache
 .ruff_cache
+.ty_cache
 .uv-cache
 
 # Virtual envs

CONTRIBUTING.md

@@ -46,7 +46,7 @@ make format
 
 ### Type checking
 
-Type checking is handled by [mypy](https://mypy.readthedocs.io/), verifying code against type annotations. Configuration settings can be found in `pyproject.toml`.
+Type checking is handled by [ty](https://docs.astral.sh/ty/), verifying code against type annotations. Configuration settings can be found in `pyproject.toml`.
 
 To run type checking:
 

Makefile

@@ -6,7 +6,7 @@
 INTEGRATION_TESTS_CONCURRENCY = 1
 
 clean:
-	rm -rf .mypy_cache .pytest_cache .ruff_cache build dist htmlcov .coverage
+	rm -rf .ty_cache .pytest_cache .ruff_cache build dist htmlcov .coverage
 
 install-dev:
 	uv sync --all-extras
@@ -24,7 +24,7 @@ lint:
 	uv run ruff check
 
 type-check:
-	uv run mypy
+	uv run ty check
 
 unit-tests:
 	uv run pytest \

docs/02_concepts/code/03_nested_async.py

@@ -13,7 +13,7 @@ async def main() -> None:
     actor_runs = (await runs_client.list(limit=10, desc=True)).items
 
     # Select the last run of the Actor that finished with a SUCCEEDED status
-    last_succeeded_run_client = actor_client.last_run(status='SUCCEEDED')  # type: ignore[arg-type]
+    last_succeeded_run_client = actor_client.last_run(status='SUCCEEDED')  # ty: ignore[invalid-argument-type]
 
     # Get dataset
     actor_run_dataset_client = last_succeeded_run_client.dataset()

docs/02_concepts/code/03_nested_sync.py

@@ -13,7 +13,7 @@ def main() -> None:
     actor_runs = runs_client.list(limit=10, desc=True).items
 
     # Select the last run of the Actor that finished with a SUCCEEDED status
-    last_succeeded_run_client = actor_client.last_run(status='SUCCEEDED')  # type: ignore[arg-type]
+    last_succeeded_run_client = actor_client.last_run(status='SUCCEEDED')  # ty: ignore[invalid-argument-type]
 
     # Get dataset
     actor_run_dataset_client = last_succeeded_run_client.dataset()

pyproject.toml

@@ -44,7 +44,6 @@ dependencies = [
 dev = [
     "dycw-pytest-only<3.0.0",
     "griffe",
-    "mypy~=1.19.0",
     "pre-commit<5.0.0",
     "pydoc-markdown<5.0.0",
     "pytest-asyncio<2.0.0",
@@ -56,6 +55,7 @@ dev = [
     "redbaron<1.0.0",
     "ruff~=0.14.0",
     "setuptools", # setuptools are used by pytest but not explicitly required
+    "ty~=0.0.0",
     "types-colorama<0.5.0",
     "werkzeug<4.0.0", # Werkzeug is used by pytest-httpserver
 ]
@@ -158,30 +158,21 @@ asyncio_default_fixture_loop_scope = "function"
 asyncio_mode = "auto"
 timeout = 1200
 
-[tool.mypy]
-python_version = "3.10"
-files = ["src", "tests", "scripts", "docs", "website"]
-check_untyped_defs = true
-disallow_incomplete_defs = true
-disallow_untyped_calls = true
-disallow_untyped_decorators = true
-disallow_untyped_defs = true
-no_implicit_optional = true
-warn_redundant_casts = true
-warn_return_any = true
-warn_unreachable = true
-warn_unused_ignores = true
-exclude = []
-
-[[tool.mypy.overrides]]
-module = ["pandas"]
-ignore_missing_imports = true
-
-[tool.basedpyright]
-pythonVersion = "3.10"
-typeCheckingMode = "standard"
+[tool.ty.environment]
+python-version = "3.10"
+
+[tool.ty.src]
 include = ["src", "tests", "scripts", "docs", "website"]
 
+[[tool.ty.overrides]]
+include = [
+    "docs/**/*.py",
+    "website/**/*.py",
+]
+
+[tool.ty.overrides.rules]
+unresolved-import = "ignore"
+
 [tool.coverage.report]
 exclude_lines = ["pragma: no cover", "if TYPE_CHECKING:", "assert_never()"]
 

scripts/check_async_docstrings.py

@@ -6,7 +6,7 @@
 import sys
 from pathlib import Path
 
-from redbaron import RedBaron  # type: ignore[import-untyped]
+from redbaron import RedBaron
 from utils import sync_to_async_docstring
 
 found_issues = False

scripts/fix_async_docstrings.py

@@ -3,7 +3,7 @@
 import re
 from pathlib import Path
 
-from redbaron import RedBaron  # type: ignore[import-untyped]
+from redbaron import RedBaron
 from utils import sync_to_async_docstring
 
 # Get the directory of the source files

src/apify_client/_logging.py

@@ -59,7 +59,7 @@ def _injects_client_details_to_log_context(fun: Callable) -> Callable:
 
         @functools.wraps(fun)
         async def async_wrapper(resource_client: _BaseBaseClient, *args: Any, **kwargs: Any) -> Any:
-            log_context.client_method.set(fun.__qualname__)
+            log_context.client_method.set(fun.__qualname__)  # ty: ignore[unresolved-attribute]
             log_context.resource_id.set(resource_client.resource_id)
 
             return await fun(resource_client, *args, **kwargs)
@@ -69,7 +69,7 @@ async def async_wrapper(resource_client: _BaseBaseClient, *args: Any, **kwargs:
 
         @functools.wraps(fun)
         async def async_generator_wrapper(resource_client: _BaseBaseClient, *args: Any, **kwargs: Any) -> Any:
-            log_context.client_method.set(fun.__qualname__)
+            log_context.client_method.set(fun.__qualname__)  # ty: ignore[unresolved-attribute]
             log_context.resource_id.set(resource_client.resource_id)
 
             async for item in fun(resource_client, *args, **kwargs):
@@ -80,7 +80,7 @@ async def async_generator_wrapper(resource_client: _BaseBaseClient, *args: Any,
 
         @functools.wraps(fun)
         def wrapper(resource_client: _BaseBaseClient, *args: Any, **kwargs: Any) -> Any:
-            log_context.client_method.set(fun.__qualname__)
+            log_context.client_method.set(fun.__qualname__)  # ty: ignore[unresolved-attribute]
             log_context.resource_id.set(resource_client.resource_id)
 
             return fun(resource_client, *args, **kwargs)

src/apify_client/_types.py

@@ -3,9 +3,8 @@
 from typing import Any, Generic, TypeVar
 
 JSONSerializable = str | int | float | bool | None | dict[str, Any] | list[Any]
-"""Type for representing json-serializable values. It's close enough to the real thing supported
-by json.parse, and the best we can do until mypy supports recursive types. It was suggested in
-a discussion with (and approved by) Guido van Rossum, so I'd consider it correct enough.
+"""Type for representing json-serializable values. It's close enough to the real thing supported by json.parse.
+It was suggested in a discussion with (and approved by) Guido van Rossum, so I'd consider it correct enough.
 """
 
 T = TypeVar('T')