Skip to content

Conversation

@BoD
Copy link
Contributor

@BoD BoD commented Dec 8, 2025

@BoD BoD requested a review from martinbonnin as a code owner December 8, 2025 13:36
@apollo-librarian
Copy link

apollo-librarian bot commented Dec 8, 2025

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: d1507cf53614e1453e559ce4
Build Logs: View logs

Comment on lines +51 to +52
.replace("/*", "/*")
.replace("*/", "*/")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This means code blocks containing /* will probably not be rendered correctly, right? It's better than code not compiling I guess.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No actually I checked, and that's rendered correctly in the IDE and in the generated KDoc

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this string:

```
*
```

Is rendered as this codeblock:

/*

Then how does one displays * in a codeblock?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how does one displays * in a codeblock?

You have to escape the &:

/**
 * /*
 *
 * *
 */

shows like:

Screenshot 2025-12-08 at 18 49 48

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about this?

/**
 * generates some foo!
 * example:
 * 
 * ```kotlin
 * /* this is how you do it! */
 * val foo = doFoo()
 * ```
 */
fun doFoo() = TODO()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh yes indeed it doesn't work inside code blocks :(

Screenshot 2025-12-08 at 18 58 03

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine by me, especially if the current state is to generate non-compiling code but probably means the "good" fix needs to be in Kotlin somewhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants