From a8707ece10e4055ee434f2bfed42a8ffb481427b Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed, 27 Nov 2024 11:42:26 +0000 Subject: [PATCH 1/2] chore(deps-dev): update rubocop requirement from = 1.68.0 to = 1.69.0 Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](https://github.com/rubocop/rubocop/compare/v1.68.0...v1.69.0) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:development ... Signed-off-by: dependabot[bot] --- appium_lib_core.gemspec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/appium_lib_core.gemspec b/appium_lib_core.gemspec index 4e32125e..5220eb55 100644 --- a/appium_lib_core.gemspec +++ b/appium_lib_core.gemspec @@ -29,7 +29,7 @@ Gem::Specification.new do |spec| spec.add_development_dependency 'minitest-reporters', '~> 1.1' spec.add_development_dependency 'parallel_tests' spec.add_development_dependency 'rake', '~> 13.0' - spec.add_development_dependency 'rubocop', '1.68.0' + spec.add_development_dependency 'rubocop', '1.69.0' spec.add_development_dependency 'simplecov' spec.add_development_dependency 'steep', '~> 1.7.0' spec.add_development_dependency 'webmock', '~> 3.24.0' From fa932284c71233fc307ccd1d63eae860bc3db381 Mon Sep 17 00:00:00 2001 From: Kazuaki Matsuo Date: Thu, 28 Nov 2024 07:38:08 +0000 Subject: [PATCH 2/2] fix rubocop --- lib/appium_lib_core/driver.rb | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/appium_lib_core/driver.rb b/lib/appium_lib_core/driver.rb index 0df6e8be..4cb25bce 100644 --- a/lib/appium_lib_core/driver.rb +++ b/lib/appium_lib_core/driver.rb @@ -394,7 +394,6 @@ def setup_for_new_session(opts = {}) def start_driver(server_url: nil, http_client_ops: { http_client: nil, open_timeout: 999_999, read_timeout: 999_999 }) - @custom_url ||= "http://127.0.0.1:#{@port}/wd/hub" @custom_url = server_url unless server_url.nil? @@ -446,7 +445,6 @@ def start_driver(server_url: nil, # Attach to an existing session def attach_to(session_id, url: nil, automation_name: nil, platform_name: nil, http_client_ops: { http_client: nil, open_timeout: 999_999, read_timeout: 999_999 }) - raise ::Appium::Core::Error::ArgumentError, 'The :url must not be nil' if url.nil? raise ::Appium::Core::Error::ArgumentError, 'The :automation_name must not be nil' if automation_name.nil? raise ::Appium::Core::Error::ArgumentError, 'The :platform_name must not be nil' if platform_name.nil?