Rename linesToMergedStr in monitor-utils

Renames the method linesToMergedStr to joinLines in the serial monitor
utils. This brings the name more in line with truncateLines. No
functionality changes.

Author: 502E532E

arduino-ide-extension/src/browser/serial/monitor/monitor-utils.ts

@@ -68,6 +68,6 @@ export function truncateLines(
   return [lines, charCount];
 }
 
-export function linesToMergedStr(lines: Line[]): string {
+export function joinLines(lines: Line[]): string {
   return lines.map((line: Line) => line.message).join('');
 }

arduino-ide-extension/src/browser/serial/monitor/serial-monitor-send-output.tsx

@@ -3,7 +3,7 @@ import { Event } from '@theia/core/lib/common/event';
 import { DisposableCollection } from '@theia/core/lib/common/disposable';
 import { areEqual, FixedSizeList as List } from 'react-window';
 import dateFormat from 'dateformat';
-import { messagesToLines, truncateLines, linesToMergedStr } from './monitor-utils';
+import { messagesToLines, truncateLines, joinLines } from './monitor-utils';
 import { MonitorManagerProxyClient } from '../../../common/protocol';
 import { MonitorModel } from '../../monitor-model';
 import { ClipboardService } from '@theia/core/lib/browser/clipboard-service';
@@ -76,7 +76,7 @@ export class SerialMonitorOutput extends React.Component<
         this.setState({ lines: [], charCount: 0 })
       ),
       this.props.copyOutputEvent(() => 
-        this.props.clipboardService.writeText(linesToMergedStr(this.state.lines))
+        this.props.clipboardService.writeText(joinLines(this.state.lines))
       ),
       this.props.monitorModel.onChange(({ property }) => {
         if (property === 'timestamp') {

arduino-ide-extension/src/test/browser/monitor-utils.test.ts

@@ -2,7 +2,7 @@ import { expect } from 'chai';
 import {
   messagesToLines,
   truncateLines,
-  linesToMergedStr,
+  joinLines,
 } from '../../browser/serial/monitor/monitor-utils';
 import { Line } from '../../browser/serial/monitor/serial-monitor-send-output';
 import { set, reset } from 'mockdate';
@@ -16,15 +16,15 @@ type TestLine = {
     charCount: number;
     maxCharacters?: number;
   };
-  expectedMerged?: string;
+  expectedJoined?: string;
 };
 
 const date = new Date();
 const testLines: TestLine[] = [
   {
     messages: ['Hello'],
     expected: { lines: [{ message: 'Hello', lineLen: 5 }], charCount: 5 },
-    expectedMerged: 'Hello',
+    expectedJoined: 'Hello',
   },
   {
     messages: ['Hello', 'Dog!'],
@@ -39,7 +39,7 @@ const testLines: TestLine[] = [
       ],
       charCount: 10,
     },
-    expectedMerged: 'Hello\nDog!'
+    expectedJoined: 'Hello\nDog!'
   },
   {
     messages: ['Dog!'],
@@ -71,7 +71,7 @@ const testLines: TestLine[] = [
         { message: "You're a good boy!", lineLen: 8 },
       ],
     },
-    expectedMerged: "Hello Dog!\n Who's a good boy?\nYou're a good boy!",
+    expectedJoined: "Hello Dog!\n Who's a good boy?\nYou're a good boy!",
   },
   {
     messages: ['boy?\n', "You're a good boy!"],
@@ -121,7 +121,7 @@ const testLines: TestLine[] = [
         { message: 'Yo', lineLen: 2 },
       ],
     },
-    expectedMerged: "Hello Dog!\nWho's a good boy?\nYo",
+    expectedJoined: "Hello Dog!\nWho's a good boy?\nYo",
   },
 ];
 
@@ -171,9 +171,9 @@ describe('Monitor Utils', () => {
           });
           expect(totalCharCount).to.equal(charCount);
         }
-        if (testLine.expectedMerged) {
-          const merged_str = linesToMergedStr(testLine.expected.lines);
-          expect(merged_str).to.equal(testLine.expectedMerged);
+        if (testLine.expectedJoined) {
+          const joined_str = joinLines(testLine.expected.lines);
+          expect(joined_str).to.equal(testLine.expectedJoined);
         }
       });
     });