task test refactor

Author: dido18

.github/workflows/test-go-task.yml

@@ -99,8 +99,7 @@ jobs:
       - name: Run tests
         env:
           GO_MODULE_PATH: ${{ matrix.module.path }}
-        # run: task go:test  ## TODO: refactor the tests
-        run: task go:test:docker
+        run: task go:test
 
       - name: Send unit tests coverage to Codecov
         if: runner.os == 'Linux'

Taskfile.yaml

@@ -1,4 +1,3 @@
-
 version: "3"
 
 vars:
@@ -11,9 +10,6 @@ vars:
         go list ./... | tr '\n' ' ' ||
         echo '"ERROR: Unable to discover Go packages"'
       )
-  # `-ldflags` flag to use for `go build` command
-  # TODO: define flag if required by the project, or leave empty if not needed.
-  LDFLAGS:
 
 tasks:
   # Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/assets/check-go-task/Taskfile.yml
@@ -47,19 +43,6 @@ tasks:
   go:test:
     desc: Run unit tests
     dir: "{{default .DEFAULT_GO_MODULE_PATH .GO_MODULE_PATH}}"
-    cmds:
-      - |
-        go test \
-          -v \
-          -short \
-          -run '{{default ".*" .GO_TEST_REGEX}}' \
-          {{default "-timeout 10m -coverpkg=./... -covermode=atomic" .GO_TEST_FLAGS}} \
-          -coverprofile=coverage_unit.txt \
-          {{.TEST_LDFLAGS}} \
-          {{default .DEFAULT_GO_PACKAGES .GO_PACKAGES}}
-
-  go:test:docker:
-    desc: Run the tests inside a docker image
     cmds:
       - docker build -f testdata/Dockerfile -t go-apt-test:latest .
-      - docker run --rm go-apt-test
+      - docker run --rm -v "$PWD":/app go-apt-test -v -short  -run '{{default ".*" .GO_TEST_REGEX}}' {{default "-timeout 10m -coverpkg=./... -covermode=atomic" .GO_TEST_FLAGS}} -coverprofile=coverage_unit.txt  {{default .DEFAULT_GO_PACKAGES .GO_PACKAGES}}

apt_test.go

@@ -71,7 +71,7 @@ func TestCheckForUpdates(t *testing.T) {
 }
 
 func TestParseListUpgradableOutput(t *testing.T) {
-	t.Run("special cases", func(t *testing.T) {
+	t.Run("edges cases", func(t *testing.T) {
 		tests := []struct {
 			name     string
 			input    string
@@ -84,7 +84,7 @@ func TestParseListUpgradableOutput(t *testing.T) {
 			},
 			{
 				name:     "line not matching regex",
-				input:    "this-is-not-a-valid-line\n",
+				input:    "this-is-not a-valid-line\n",
 				expected: []*Package{},
 			},
 			{

testdata/Dockerfile

@@ -10,10 +10,10 @@ RUN apt-get update && apt-get install -y \
 WORKDIR /app
 
 # Copy everything (mod files + code)
-COPY . .
+COPY go.mod go.sum ./
 
 # Download modules
 RUN go mod download
 
 # Run tests in apt package
-CMD ["go", "test", "-v", "./"]
+ENTRYPOINT ["go", "test"]