remove docker

Author: dido18

Taskfile.yaml

@@ -1,3 +1,4 @@
+
 version: "3"
 
 vars:
@@ -10,6 +11,9 @@ vars:
         go list ./... | tr '\n' ' ' ||
         echo '"ERROR: Unable to discover Go packages"'
       )
+  # `-ldflags` flag to use for `go build` command
+  # TODO: define flag if required by the project, or leave empty if not needed.
+  LDFLAGS:
 
 tasks:
   # Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/assets/check-go-task/Taskfile.yml
@@ -44,5 +48,12 @@ tasks:
     desc: Run unit tests
     dir: "{{default .DEFAULT_GO_MODULE_PATH .GO_MODULE_PATH}}"
     cmds:
-      - docker build -f testdata/Dockerfile -t go-apt-test:latest .
-      - docker run --rm -v "$PWD":/app go-apt-test -v -short  -run '{{default ".*" .GO_TEST_REGEX}}' {{default "-timeout 10m -coverpkg=./... -covermode=atomic" .GO_TEST_FLAGS}} -coverprofile=coverage_unit.txt  {{default .DEFAULT_GO_PACKAGES .GO_PACKAGES}}
+      - |
+        go test \
+          -v \
+          -short \
+          -run '{{default ".*" .GO_TEST_REGEX}}' \
+          {{default "-timeout 10m -coverpkg=./... -covermode=atomic" .GO_TEST_FLAGS}} \
+          -coverprofile=coverage_unit.txt \
+          {{.TEST_LDFLAGS}} \
+          {{default .DEFAULT_GO_PACKAGES .GO_PACKAGES}}

apt.go

@@ -86,6 +86,7 @@ func parseDpkgQueryOutput(out []byte) []*Package {
 
 // CheckForUpdates runs an apt update to retrieve new packages available
 // from the repositories
+// NOTE: it requires root privileges to run
 func CheckForUpdates() (output []byte, err error) {
 	cmd := exec.Command("apt-get", "update", "-q")
 	return cmd.CombinedOutput()

apt_test.go

@@ -63,13 +63,6 @@ func TestListUpgradable(t *testing.T) {
 	require.NoError(t, err, "running List command")
 }
 
-func TestCheckForUpdates(t *testing.T) {
-	out, err := CheckForUpdates()
-	require.NoError(t, err, "running CheckForUpdate command")
-	fmt.Printf(">>>\n%s\n<<<\n", string(out))
-	fmt.Println("ERR:", err)
-}
-
 func TestParseListUpgradableOutput(t *testing.T) {
 	t.Run("edges cases", func(t *testing.T) {
 		tests := []struct {